-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improved translation into Russian language #14412
chore: Improved translation into Russian language #14412
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14412 +/- ##
==========================================
- Coverage 77.31% 77.06% -0.26%
==========================================
Files 958 958
Lines 48287 48268 -19
Branches 5658 5645 -13
==========================================
- Hits 37335 37196 -139
- Misses 10750 10871 +121
+ Partials 202 201 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! I've asked around to see if anyone knows Russian and can review, but if not I'll plan to merge in a couple days
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some charts are translated to Russian, some - not. Such as - Heatmap and Bubble chart and etc. Also - DELETE and OVERWRITE no need to be translated - otherwise user might have a confuse when typing "УДАЛИТЬ" and nothing happen on backend.
Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for hard working!
This is great, thank you! |
Looks like the linter needs to be run on the translations file (see the failing CI). otherwise lgtm! |
Fixed with 'npx prettier --write' |
Sorry, looks like this needs to be rebased too :'( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have an internal native speaker looked at the pr, looks good to us.
approving from the product standpoint. @rusackas @etr2460 🟢 i will let you press the green button.
please do rebase 🙏
"I've screened the PR, an it looks good, I mean it looks like it was a native speaker who did the translation, or translator tools became very smart)"
Ha-ha, thank you! I'm definitely a native speaker :) |
* fix: SQLLab role permissions * add missing perm * fix tests * fix security test * fix security test * fix tests
* Add aria-label and twotone * Enhance LazyIcon * Fix tests and solve ject warnings * Add new line * Revert package-lock to master * Fix failing test * Implement icon overrides * Fix failing storybook * Clean up * Improve var name
* add limiting factor to query model * varchar instead of enum
…la from impala in index.mdx (#14425)
* fix parsing error messages that are formatted as single strings * fix other instances of error typing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for wrestling with CI, this is good to go now!
SUMMARY
Improved translation to Russian language.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TEST PLAN
ADDITIONAL INFORMATION