refactor(native-filters): allow cascading only for filter_select #14441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
� Conflicts: � superset-frontend/src/dashboard/util/getPermissions.ts
Codecov Report
@@ Coverage Diff @@
## master #14441 +/- ##
==========================================
+ Coverage 76.79% 76.99% +0.20%
==========================================
Files 955 955
Lines 48247 48029 -218
Branches 6030 6040 +10
==========================================
- Hits 37051 36981 -70
+ Misses 11001 10850 -151
- Partials 195 198 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
amitmiran137
approved these changes
May 2, 2021
| @@ -186,6 +189,8 @@ export const FiltersConfigForm: React.FC<FiltersConfigFormProps> = ({ | |||
| formFilter?.filterType, | |||
| ); | |||
|
|
|||
| const isCascadingFilter = CASCADING_FILTERS.includes(formFilter?.filterType); | |||
There was a problem hiding this comment.
Suggested change
| const isCascadingFilter = CASCADING_FILTERS.includes(formFilter?.filterType); | |
| const isCascadingFilterAllowed = CASCADING_FILTERS.includes(formFilter?.filterType); |
| isClearable | ||
| /> | ||
| </StyledFormItem> | ||
| {isCascadingFilter && ( |
There was a problem hiding this comment.
Suggested change
| {isCascadingFilter && ( | |
| {isCascadingFilterAllowed && ( |
amitmiran137
pushed a commit
to nielsen-oss/superset
that referenced
this pull request
May 3, 2021
* master: (38 commits) refactor(native-filters): allow cascading only for filter_select (apache#14441) test(maximize-chart): Add tests to maximize chart action (apache#14371) fix: fixing mysql error message (apache#14416) feat: Logic added to limiting factor column in Query model (apache#13521) change relationship (apache#14435) fix: bootstrap data permissions (apache#14348) fix: parse simple string error message values (apache#14360) chore: add stack trace to all calls of logger.error (apache#14382) update README with new docs and recordings (apache#14432) Renamed impyla from implya in impala.mdx and Renamed PIP package impyla from impala in index.mdx (apache#14425) fix(native-filters): fix filter scope error (apache#14426) feat: Adding limiting_factor column to Query model (apache#14234) feat: Add etag caching to dashboard APIs (apache#14357) chore: Moves Card to the components folder (apache#14139) feat: Dynamic imports for the Icons component (apache#14318) feat: Support env vars configuration for WebSocket server (apache#14398) fix: SQLLab role permissions (apache#14372) fix(native-filters): always show filters without dataset (apache#14409) fix error getting partitionQuery from table.partition (apache#14369) refactor: Boostrap to AntD - Tabs (apache#14048) ...
amitmiran137
pushed a commit
that referenced
this pull request
May 4, 2021
) * fix:fix get permission function * refactor: allow cascading only for filter_select (cherry picked from commit abbf4bf)
junlincc
added
the
dashboard:native-filters
|
a bit too late, but thanks for making the change! @simcha90 @amitmiran137 |
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Sep 8, 2021
…che#14441) * fix:fix get permission function * refactor: allow cascading only for filter_select (cherry picked from commit abbf4bf)
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
…che#14441) * fix:fix get permission function * refactor: allow cascading only for filter_select
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…che#14441) * fix:fix get permission function * refactor: allow cascading only for filter_select
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…che#14441) * fix:fix get permission function * refactor: allow cascading only for filter_select
mistercrunch
added
🍒 1.2.0
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Allows apply cascading logic only for Select filters
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION