-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixes right menu layout in different screen sizes #14689
Conversation
/testenv up |
ccb9bd7
to
7365a73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled the code and LGTM! Thanks for the fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #14689 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 959 959
Lines 48648 48655 +7
Branches 5734 5735 +1
=======================================
+ Hits 37718 37725 +7
Misses 10729 10729
Partials 201 201
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@junlincc Ephemeral environment spinning up at http://54.214.160.222:8080. Credentials are |
7365a73
to
4b91a42
Compare
@pkdotson To fix this I changed the style of |
hi!menu items seem not aligned on resize? |
My last commit fixed @pkdotson comment. The ephemeral env was not updated though. |
/testenv up |
@rusackas Ephemeral environment spinning up at http://34.220.89.138:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, works with and without the language menu displayed.
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Fixes #14649.
@rusackas @junlincc @pkdotson
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
screen-recording-2021-05-18-at-81831-am_PsMjueN7.mov
screen-recording-2021-05-18-at-81303-am_sYloDaxy.mov
TEST PLAN
1 - Resize screen
2 - Check the right menu behaviour
ADDITIONAL INFORMATION