Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hiding HiddenControl inputs for real, so they don't add height #15182

Merged
merged 2 commits into from
Nov 23, 2021

Conversation

rusackas
Copy link
Member

SUMMARY

There are (or were) some hidden inputs in the Explore control panel, which were taking up about a pixel each vertically, thanks to Bootstrap. This PR simply adds a display:none to the controls that are of type HiddenControl to take them out of the DOM layout. They should still submit properly in all modern-ish browsers.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Coming soon...

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #15182 (80d0c33) into master (c829614) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15182   +/-   ##
=======================================
  Coverage   76.94%   76.94%           
=======================================
  Files        1042     1042           
  Lines       56254    56255    +1     
  Branches     7785     7786    +1     
=======================================
+ Hits        43286    43287    +1     
  Misses      12710    12710           
  Partials      258      258           
Flag Coverage Δ
hive 81.53% <ø> (ø)
javascript 71.02% <100.00%> (+<0.01%) ⬆️
mysql 81.95% <ø> (ø)
postgres 81.96% <ø> (ø)
presto 81.83% <ø> (ø)
python 82.46% <ø> (ø)
sqlite 81.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-frontend/src/explore/components/ControlRow.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c829614...80d0c33. Read the comment docs.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 6d66963 into master Nov 23, 2021
@rusackas rusackas deleted the hiding-hidden-controls-for-real branch November 23, 2021 23:08
AAfghahi pushed a commit that referenced this pull request Jan 10, 2022
…consumption (#15182)

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants