Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: passing url params in sqllab #15246

Merged
merged 3 commits into from
Feb 15, 2022
Merged

fix: passing url params in sqllab #15246

merged 3 commits into from
Feb 15, 2022

Conversation

maltoze
Copy link
Contributor

@maltoze maltoze commented Jun 18, 2021

SUMMARY

Fixes: #13315

BEFORE

image

AFTER

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 22, 2021

Codecov Report

Merging #15246 (5862ce7) into master (5bb406b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 5862ce7 differs from pull request most recent head 4a55452. Consider uploading reports for the commit 4a55452 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15246   +/-   ##
=======================================
  Coverage   66.32%   66.32%           
=======================================
  Files        1620     1620           
  Lines       63060    63061    +1     
  Branches     6368     6368           
=======================================
+ Hits        41823    41824    +1     
  Misses      19579    19579           
  Partials     1658     1658           
Flag Coverage Δ
javascript 51.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/SqlLab/actions/sqlLab.js 60.51% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bb406b...4a55452. Read the comment docs.

@egeste
Copy link

egeste commented Oct 4, 2021

Bump

@egeste
Copy link

egeste commented Dec 24, 2021

How can I help move this PR along?

@villebro
Copy link
Member

Thanks so much for this fix @maltoze and sorry for it slipping through the cracks 🙁 I'll work on pushing this through now.

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@villebro villebro merged commit 57c4d0f into apache:master Feb 15, 2022
@maltoze maltoze deleted the fix/url_param-sqllab branch February 16, 2022 03:43
@egeste
Copy link

egeste commented Feb 16, 2022

🎉 🎉 🎉 🎉

When will this be available in a release?

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to Use Jinja Context for "url_param"
6 participants