Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dropdown placement for cascading filters popover #17046

Merged
merged 14 commits into from
Oct 22, 2021
Merged

fix: dropdown placement for cascading filters popover #17046

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
4748e6c
inital fix
pkdotson Oct 8, 2021
530eab0
remove content wrapper
pkdotson Oct 11, 2021
8c3b0c1
allow dropdown to overflow in long chart
pkdotson Oct 14, 2021
e2145b5
Merge branch 'master' of https://github.com/preset-io/superset into f…
pkdotson Oct 15, 2021
28ea985
only pass through filtercontrol
pkdotson Oct 15, 2021
8864ae1
change to auto
pkdotson Oct 15, 2021
b1abda4
add ref and pass to child
pkdotson Oct 18, 2021
5f863da
fix bug
pkdotson Oct 19, 2021
96d3562
Merge branch 'master' of https://github.com/preset-io/superset into f…
pkdotson Oct 19, 2021
dc671ab
fix lint
pkdotson Oct 19, 2021
3d5f23b
add type
pkdotson Oct 19, 2021
d92867d
remove code
pkdotson Oct 20, 2021
8a15259
add currrent param
pkdotson Oct 21, 2021
8cf017b
Merge branch 'fix-popover-dropdown' of https://github.com/preset-io/s…
pkdotson Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .../src/dashboard/components/nativeFilters/FilterBar/CascadeFilters/CascadePopover/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,10 @@ const StyledPill = styled(Pill)`

const ContentWrapper = styled.div`
max-height: 700px;
overflow-y: auto;
.ant-select-dropdown {
// ensures dropdown positions correctly
top: 36px !important;
pkdotson marked this conversation as resolved.
Show resolved Hide resolved
}
`;

const CascadePopover: React.FC<CascadePopoverProps> = ({
Expand Down