Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove title from the Cancel SVG #17147

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

AAfghahi
Copy link
Member

SUMMARY

There was a title on the cancel svg which was showing up as a tooltip. This comments it out in case we want to bring it back at some point.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen Shot 2021-10-18 at 3 47 44 PM

After:

Screen.Recording.2021-10-18.at.3.44.11.PM.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #17147 (3019623) into master (96f4421) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17147   +/-   ##
=======================================
  Coverage   76.91%   76.91%           
=======================================
  Files        1038     1038           
  Lines       55557    55557           
  Branches     7567     7567           
=======================================
  Hits        42731    42731           
  Misses      12576    12576           
  Partials      250      250           
Flag Coverage Δ
javascript 70.93% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96f4421...3019623. Read the comment docs.

@hughhhh hughhhh self-requested a review October 18, 2021 21:03
@hughhhh hughhhh merged commit dacf797 into apache:master Oct 18, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants