Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: remove redundant parentheses from setup.py #17284

Merged
merged 1 commit into from
Nov 1, 2021
Merged

style: remove redundant parentheses from setup.py #17284

merged 1 commit into from
Nov 1, 2021

Conversation

PApostol
Copy link
Contributor

SUMMARY

This PR removes the redundant parentheses from description string in setup.py.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #17284 (660eb53) into master (f0c0ef7) will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17284      +/-   ##
==========================================
- Coverage   77.04%   76.82%   -0.22%     
==========================================
  Files        1037     1037              
  Lines       55635    55635              
  Branches     7594     7594              
==========================================
- Hits        42863    42742     -121     
- Misses      12522    12643     +121     
  Partials      250      250              
Flag Coverage Δ
hive ?
mysql 81.97% <ø> (ø)
postgres 81.98% <ø> (ø)
presto ?
python 82.06% <ø> (-0.42%) ⬇️
sqlite 81.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 69.76% <0.00%> (-17.06%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-6.91%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 85.76% <0.00%> (-1.64%) ⬇️
superset/models/core.py 89.26% <0.00%> (-0.74%) ⬇️
superset/db_engine_specs/base.py 88.20% <0.00%> (-0.39%) ⬇️
superset/utils/core.py 90.02% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0c0ef7...660eb53. Read the comment docs.

Copy link
Member

@etr2460 etr2460 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, thanks for the contribution!

@etr2460 etr2460 merged commit a898883 into apache:master Nov 1, 2021
@PApostol PApostol deleted the remove-redundant-parentheses branch November 1, 2021 16:17
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants