Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqla): Adhere to series limit ordering for pre-query #17388

Merged
merged 1 commit into from
Jan 11, 2022

Conversation

john-bodley
Copy link
Member

SUMMARY

This PR fixes an almost three year old regression defined in #6862 where if a sort-by metric was defined for a pre-query the ordering wasn't adhered to.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Tested locally. This logic is somewhat challenging to add unit tests for given the scale of the function. Ideally this should be modularized to improve the ability to write concise unit tests.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #17388 (466221f) into master (7d22c9c) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17388   +/-   ##
=======================================
  Coverage   77.02%   77.02%           
=======================================
  Files        1038     1038           
  Lines       56013    56013           
  Branches     7735     7735           
=======================================
+ Hits        43142    43144    +2     
+ Misses      12613    12611    -2     
  Partials      258      258           
Flag Coverage Δ
hive 81.48% <ø> (ø)
mysql 81.90% <ø> (ø)
postgres 81.91% <ø> (ø)
presto 81.78% <ø> (+<0.01%) ⬆️
python 82.42% <ø> (+<0.01%) ⬆️
sqlite 81.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/connectors/sqla/models.py 87.97% <ø> (ø)
superset/db_engine_specs/presto.py 90.37% <0.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d22c9c...466221f. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-bodley john-bodley merged commit ce614ea into apache:master Jan 11, 2022
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
Co-authored-by: John Bodley <john.bodley@airbnb.com>
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
Co-authored-by: John Bodley <john.bodley@airbnb.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants