Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dashboard API flaky test #17611

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Uses freezegun to fix a dashboard API flaky test.

TESTING INSTRUCTIONS

1 - Execute all tests
2 - All tests should pass

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #17611 (f430826) into master (d7e3a60) will decrease coverage by 0.14%.
The diff coverage is 60.64%.

❗ Current head f430826 differs from pull request most recent head 8ccf618. Consider uploading reports for the commit 8ccf618 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17611      +/-   ##
==========================================
- Coverage   68.59%   68.44%   -0.15%     
==========================================
  Files        1588     1601      +13     
  Lines       64948    65258     +310     
  Branches     6963     6963              
==========================================
+ Hits        44548    44664     +116     
- Misses      18510    18704     +194     
  Partials     1890     1890              
Flag Coverage Δ
hive ?
mysql 81.80% <60.64%> (-0.23%) ⬇️
postgres 81.81% <60.64%> (-0.23%) ⬇️
presto 81.67% <60.64%> (-0.23%) ⬇️
python 82.06% <60.64%> (-0.48%) ⬇️
sqlite 81.49% <60.64%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/key_value/api.py 41.46% <41.46%> (ø)
superset/dashboards/filter_state/commands/get.py 50.00% <50.00%> (ø)
superset/key_value/commands/create.py 57.14% <57.14%> (ø)
superset/key_value/commands/get.py 57.14% <57.14%> (ø)
superset/key_value/commands/update.py 57.69% <57.69%> (ø)
superset/key_value/commands/delete.py 60.00% <60.00%> (ø)
...uperset/dashboards/filter_state/commands/create.py 63.63% <63.63%> (ø)
...uperset/dashboards/filter_state/commands/delete.py 63.63% <63.63%> (ø)
...uperset/dashboards/filter_state/commands/update.py 63.63% <63.63%> (ø)
superset/key_value/utils.py 75.00% <75.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7e3a60...8ccf618. Read the comment docs.

@michael-s-molina michael-s-molina merged commit 78c5d9a into apache:master Dec 1, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants