Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert feature flag tests to unit tests #17689

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Dec 8, 2021

SUMMARY

Converted feature flag tests into unit tests.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida added the need:merge The PR is ready to be merged label Dec 8, 2021
@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #17689 (eb83ade) into master (7353a2b) will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17689      +/-   ##
==========================================
+ Coverage   76.81%   77.05%   +0.23%     
==========================================
  Files        1049     1063      +14     
  Lines       56653    57086     +433     
  Branches     7847     7847              
==========================================
+ Hits        43517    43986     +469     
+ Misses      12883    12847      -36     
  Partials      253      253              
Flag Coverage Δ
hive 81.72% <ø> (?)
mysql 82.13% <ø> (+0.12%) ⬆️
postgres 82.14% <ø> (+0.12%) ⬆️
python 82.48% <ø> (+0.38%) ⬆️
sqlite 81.82% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/feature_flag_manager.py 88.88% <0.00%> (-7.41%) ⬇️
superset/connectors/base/models.py 88.19% <0.00%> (-0.49%) ⬇️
superset/dashboards/api.py 91.86% <0.00%> (-0.29%) ⬇️
superset/charts/commands/export.py 94.11% <0.00%> (-0.17%) ⬇️
superset/cli.py 54.82% <0.00%> (-0.11%) ⬇️
superset/constants.py 100.00% <0.00%> (ø)
superset/models/reports.py 100.00% <0.00%> (ø)
superset/utils/cache_manager.py 100.00% <0.00%> (ø)
superset/db_engine_specs/hana.py 95.00% <0.00%> (ø)
superset/connectors/sqla/utils.py 92.15% <0.00%> (ø)
... and 62 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7353a2b...eb83ade. Read the comment docs.

@betodealmeida betodealmeida merged commit b7ae7f9 into apache:master Dec 8, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged size/L 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants