fix(Sql Lab tabs): Empty SQL lab tabs

[Yahyakiani]

SUMMARY

This PR fixes the problem in which all SQL Lab tabs could be closed leaving an empty window. Now instead of trying to close the last window an error modal will pop up.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:Closing all tabs on SQL Lab leaves the screen blank #17630
• Required feature flags:
• Fixes Closing all tabs on SQL Lab leaves the screen blank #17630
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[ofekisr]

I don't think popping up an error message is a good way, IMO its better to create automatically a new tab when the last tab is deleted. If the user would like to delete its tab why harden him

[kasiazjc]

Hi! I agree that adding an error message is quite agressive as there is no real reason why user cannot have all of the tabs closed (and they may want to have like this for their peace of mind).

I would say that the easiest way to go and most user friendly would be improving an error state, below is a solution that I'd like to propose

[yousoph]

I love the blank state proposal from @kasiazjc , agreed that it's more user friendly than showing an error on closing.

[villebro]

@Yahyakiani thanks so much for the contribution! My apologies for not checking in with design on the original issue in #17630 🙁 Do you think you would be able to implement the proposed design? If not we'll be happy to help; just ping me on Slack if you want to discuss!

[Yahyakiani]

@Yahyakiani thanks so much for the contribution! My apologies for not checking in with design on the original issue in #17630 🙁 Do you think you would be able to implement the proposed design? If not we'll be happy to help; just ping me on Slack if you want to discuss!

Certainly, I will let you know in case of any questions.

[Yahyakiani]

Thanks for the feed. Which can I find or import this design from ? or will I have to create it . Any direction would be helpful.

Hi! I agree that adding an error message is quite agressive as there is no real reason why user cannot have all of the tabs closed (and they may want to have like this for their peace of mind).

I would say that the easiest way to go and most user friendly would be improving an error state, below is a solution that I'd like to propose

[kasiazjc]

@Yahyakiani I added it all to the figma file. You should be able to export all of the details, objects, check the colours etc.

I do not have the correct design for the implemented tabs, so I guess you should use the spacings etc that we already have and do not mind the details of the design too much.

Let me know if you can access the file :)

[eschutho]

cc @yousoph

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

[yousoph]

Closing this PR since #18817 took it to completion