Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local warning in the frontend development #17727

Merged
merged 1 commit into from
Dec 15, 2021

Conversation

stephenLYZ
Copy link
Member

@stephenLYZ stephenLYZ commented Dec 13, 2021

SUMMARY

Currently, there were a few warnings prompted when the frontend service was started locally, and this PR fixes most of them. (Three remaining)

resolved:

WARNING in ./packages/superset-ui-chart-controls/src/components/Tooltip.tsx 23:0-48
export 'TooltipProps' (reexported as 'TooltipProps') was not found in 'antd/lib/tooltip' (possible exports: __esModule, default)

WARNING in ./packages/superset-ui-chart-controls/src/types.ts 1:295-338
export 'Metric' (reexported as 'Metric') was not found in '@superset-ui/core' (possible exports: AnnotationOpacity, AnnotationSourceType, AnnotationStyle, AnnotationType, ApiLegacy, ApiV1, AppSection, BRAND_COLOR, Behavior, BuildQuery, CategoricalAirbnb, CategoricalColorNamespace, CategoricalColorScale, CategoricalD3, CategoricalEcharts, CategoricalGoogle, CategoricalLyft, CategoricalPreset, CategoricalScheme, CategoricalSuperset, ChartClient, ChartDataProvider, ChartFrame, ChartMetadata, ChartPlugin, ChartProps, ColorSchemeRegistry, ComparisionType, DTTM_ALIAS, DatasourceKey, DatasourceType, EXTRA_FORM_DATA_APPEND_KEYS, EXTRA_FORM_DATA_OVERRIDE_EXTRA_KEYS, EXTRA_FORM_DATA_OVERRIDE_KEYS, EXTRA_FORM_DATA_OVERRIDE_REGULAR_KEYS, EXTRA_FORM_DATA_OVERRIDE_REGULAR_MAPPINGS, EmotionCacheProvider, ExtensibleFunction, FAST_DEBOUNCE, FeatureFlag, GenericDataType, LOCAL_PREFIX, NumberFormats, NumberFormatter, NumberFormatterRegistry, OverwritePolicy, PREVIEW_TIME, PREVIEW_VALUE, PandasAxis, Plugin, Preset, QueryMode, Registry, RegistryWithDefaultKey, RollingType, SLOW_DEBOUNCE, SafeMarkdown, SequentialCommon, SequentialD3, SequentialScheme, SuperChart, SupersetApiError, SupersetApiErrorType, SupersetClient, SupersetClientClass, ThemeProvider, TimeFormats, TimeFormatter, TimeGranularity, TooltipFrame, TooltipTable, WithLegend, __hack_reexport_AdvancedAnalytics, __hack_reexport_Column, __hack_reexport_Datasource, __hack_reexport_Metric, __hack_reexport_Query, __hack_reexport_QueryFormData, __hack_reexport_QueryResponse, __hack_reexport_Time, __hack_reexport_chart_Base, __hack_reexport_chart_QueryResponse, __hack_reexport_chart_TransformFunction, __hack_reexport_connection, __hack_reexport_dimension, __hack_reexport_jed, __hack_reexport_trasnslation, addLocaleData, addTranslation, addTranslations, buildQueryContext, buildQueryObject, callApi, computeMaxFontSize, configure, convertFilter, convertKeysToCamelCase, createD3NumberFormatter, createD3TimeFormatter, createDurationFormatter, createEmotionCache, createLoadableRenderer, createMultiFormatter, createSiAtMostNDigitFormatter, createSmartNumberFormatter, css, defineSharedModule, defineSharedModules, emotionCache, ensureIsArray, ensureIsInt, evalExpression, extractTimegrain, formatNumber, formatTime, formatTimeRange, getCategoricalSchemeRegistry, getChartBuildQueryRegistry, getChartComponentRegistry, getChartControlPanelRegistry, getChartMetadataRegistry, getChartTransformPropsRegistry, getColumnLabel, getContrastingColor, getMetricLabel, getMultipleTextDimensions, getNumberFormatter, getNumberFormatterRegistry, getSequentialSchemeRegistry, getTextDimension, getTimeFormatter, getTimeFormatterForGranularity, getTimeFormatterRegistry, getTimeRangeFormatter, isAdhocMetricSimple, isBinaryAdhocFilter, isBinaryOperator, isDefined, isDruidFormData, isEventAnnotationLayer, isFeatureEnabled, isFormulaAnnotationLayer, isIntervalAnnotationLayer, isPhysicalColumn, isPostProcessingAggregation, isPostProcessingBoxplot, isPostProcessingCompare, isPostProcessingContribution, isPostProcessingCum, isPostProcessingDiff, isPostProcessingPivot, isPostProcessingProphet, isPostProcessingResample, isPostProcessingRolling, isPostProcessingSort, isRecordAnnotationResult, isRequired, isSavedMetric, isSetAdhocFilter, isSetOperator, isSimpleAdhocFilter, isTableAnnotationLayer, isTimeseriesAnnotationLayer, isTimeseriesAnnotationResult, isUnaryAdhocFilter, isUnaryOperator, isValidExpression, jsx, legacyValidateInteger, legacyValidateNumber, logging, makeApi, makeSingleton, mergeMargin, normalizeOrderBy, parseLength, promiseTimeout, reactify, removeDuplicates, reset, resetTranslation, seed, seedRandom, smartDateDetailedFormatter, smartDateFormatter, smartDateVerboseFormatter, styled, supersetTheme, t, tn, useTheme, validateInteger, validateNonEmpty, validateNumber, withTheme)

WARNING in ./packages/superset-ui-chart-controls/src/types.ts 2:0-63
export 'ControlFormItemSpec' (reexported as 'ControlFormItemSpec') was not found in './components/ControlForm' (possible exports: ControlFormItem, ControlFormItemComponents, ControlFormRow, default)

WARNING in ./packages/superset-ui-chart-controls/src/types.ts 3:0-75
export 'ControlComponentProps' (reexported as 'ControlComponentProps') was not found in './shared-controls/components/types' (module has no exports)

WARNING in ./packages/superset-ui-core/src/chart/index.ts 31:0-75
export 'BuildQuery' (reexported as 'BuildQuery') was not found in './registries/ChartBuildQueryRegistrySingleton' (possible exports: default)

WARNING in ./src/common/components/index.tsx 29:0-62
export 'ModalProps' (reexported as 'ModalProps') was not found in 'antd/lib/modal' (possible exports: __esModule, default)

WARNING in ./src/common/components/index.tsx 30:0-45
export 'FormInstance' (reexported as 'FormInstance') was not found in 'antd/lib/form' (possible exports: __esModule, default)

WARNING in ./src/common/components/index.tsx 31:0-50
export 'RadioChangeEvent' (reexported as 'RadioChangeEvent') was not found in 'antd/lib/radio' (possible exports: Button, Group, __esModule, default)

WARNING in ./src/common/components/index.tsx 32:0-42
export 'TreeProps' (reexported as 'TreeProps') was not found in 'antd/lib/tree' (possible exports: __esModule, default)

WARNING in ./src/common/components/index.tsx 33:0-62
export 'AlertProps' (reexported as 'AlertProps') was not found in 'antd/lib/alert' (possible exports: __esModule, default)

WARNING in ./src/common/components/index.tsx 34:0-65
export 'SelectProps' (reexported as 'SelectProps') was not found in 'antd/lib/select' (possible exports: __esModule, default)

WARNING in ./src/common/components/index.tsx 35:0-63
export 'ListItemProps' (reexported as 'ListItemProps') was not found in 'antd/lib/list' (possible exports: ListConsumer, ListContext, __esModule, default)

WARNING in ./src/components/Form/Form.tsx 33:0-21
export 'FormProps' (reexported as 'FormProps') was not found in 'antd/lib/form' (possible exports: __esModule, default)

WARNING in ./src/components/Icons/index.tsx 162:0-20
export 'default' (reexported as 'IconType') was not found in './IconType' (module has no exports)

WARNING in ./src/components/Select/NativeSelect.tsx 22:0-105
export 'OptionType' (reexported as 'NativeSelectOptionType') was not found in 'antd/lib/select' (possible exports: __esModule, default)

WARNING in ./src/components/Select/NativeSelect.tsx 22:0-105
export 'SelectProps' (reexported as 'NativeSelectProps') was not found in 'antd/lib/select' (possible exports: __esModule, default)

WARNING in ./src/components/Slider/index.tsx 21:0-47
export 'SliderSingleProps' (reexported as 'SliderSingleProps') was not found in 'antd/lib/slider' (possible exports: __esModule, default)

WARNING in ./src/components/Slider/index.tsx 21:0-47
export 'SliderRangeProps' (reexported as 'SliderRangeProps') was not found in 'antd/lib/slider' (possible exports: __esModule, default)

WARNING in ./src/components/Switch/index.tsx 28:0-23
export 'SwitchProps' (reexported as 'SwitchProps') was not found in 'antd/lib/switch' (possible exports: __esModule, default)

WARNING in ./src/featureFlags.ts 1:295-359
export 'FeatureFlagMap' (reexported as 'FeatureFlagMap') was not found in '@superset-ui/core' (possible exports: AnnotationOpacity, AnnotationSourceType, AnnotationStyle, AnnotationType, ApiLegacy, ApiV1, AppSection, BRAND_COLOR, Behavior, BuildQuery, CategoricalAirbnb, CategoricalColorNamespace, CategoricalColorScale, CategoricalD3, CategoricalEcharts, CategoricalGoogle, CategoricalLyft, CategoricalPreset, CategoricalScheme, CategoricalSuperset, ChartClient, ChartDataProvider, ChartFrame, ChartMetadata, ChartPlugin, ChartProps, ColorSchemeRegistry, ComparisionType, DTTM_ALIAS, DatasourceKey, DatasourceType, EXTRA_FORM_DATA_APPEND_KEYS, EXTRA_FORM_DATA_OVERRIDE_EXTRA_KEYS, EXTRA_FORM_DATA_OVERRIDE_KEYS, EXTRA_FORM_DATA_OVERRIDE_REGULAR_KEYS, EXTRA_FORM_DATA_OVERRIDE_REGULAR_MAPPINGS, EmotionCacheProvider, ExtensibleFunction, FAST_DEBOUNCE, FeatureFlag, GenericDataType, LOCAL_PREFIX, NumberFormats, NumberFormatter, NumberFormatterRegistry, OverwritePolicy, PREVIEW_TIME, PREVIEW_VALUE, PandasAxis, Plugin, Preset, QueryMode, Registry, RegistryWithDefaultKey, RollingType, SLOW_DEBOUNCE, SafeMarkdown, SequentialCommon, SequentialD3, SequentialScheme, SuperChart, SupersetApiError, SupersetApiErrorType, SupersetClient, SupersetClientClass, ThemeProvider, TimeFormats, TimeFormatter, TimeGranularity, TooltipFrame, TooltipTable, WithLegend, __hack_reexport_AdvancedAnalytics, __hack_reexport_Column, __hack_reexport_Datasource, __hack_reexport_Metric, __hack_reexport_Query, __hack_reexport_QueryFormData, __hack_reexport_QueryResponse, __hack_reexport_Time, __hack_reexport_chart_Base, __hack_reexport_chart_QueryResponse, __hack_reexport_chart_TransformFunction, __hack_reexport_connection, __hack_reexport_dimension, __hack_reexport_jed, __hack_reexport_trasnslation, addLocaleData, addTranslation, addTranslations, buildQueryContext, buildQueryObject, callApi, computeMaxFontSize, configure, convertFilter, convertKeysToCamelCase, createD3NumberFormatter, createD3TimeFormatter, createDurationFormatter, createEmotionCache, createLoadableRenderer, createMultiFormatter, createSiAtMostNDigitFormatter, createSmartNumberFormatter, css, defineSharedModule, defineSharedModules, emotionCache, ensureIsArray, ensureIsInt, evalExpression, extractTimegrain, formatNumber, formatTime, formatTimeRange, getCategoricalSchemeRegistry, getChartBuildQueryRegistry, getChartComponentRegistry, getChartControlPanelRegistry, getChartMetadataRegistry, getChartTransformPropsRegistry, getColumnLabel, getContrastingColor, getMetricLabel, getMultipleTextDimensions, getNumberFormatter, getNumberFormatterRegistry, getSequentialSchemeRegistry, getTextDimension, getTimeFormatter, getTimeFormatterForGranularity, getTimeFormatterRegistry, getTimeRangeFormatter, isAdhocMetricSimple, isBinaryAdhocFilter, isBinaryOperator, isDefined, isDruidFormData, isEventAnnotationLayer, isFeatureEnabled, isFormulaAnnotationLayer, isIntervalAnnotationLayer, isPhysicalColumn, isPostProcessingAggregation, isPostProcessingBoxplot, isPostProcessingCompare, isPostProcessingContribution, isPostProcessingCum, isPostProcessingDiff, isPostProcessingPivot, isPostProcessingProphet, isPostProcessingResample, isPostProcessingRolling, isPostProcessingSort, isRecordAnnotationResult, isRequired, isSavedMetric, isSetAdhocFilter, isSetOperator, isSimpleAdhocFilter, isTableAnnotationLayer, isTimeseriesAnnotationLayer, isTimeseriesAnnotationResult, isUnaryAdhocFilter, isUnaryOperator, isValidExpression, jsx, legacyValidateInteger, legacyValidateNumber, logging, makeApi, makeSingleton, mergeMargin, normalizeOrderBy, parseLength, promiseTimeout, reactify, removeDuplicates, reset, resetTranslation, seed, seedRandom, smartDateDetailedFormatter, smartDateFormatter, smartDateVerboseFormatter, styled, supersetTheme, t, tn, useTheme, validateInteger, validateNonEmpty, validateNumber, withTheme)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #17727 (8575e40) into master (485852d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 8575e40 differs from pull request most recent head 09f6564. Consider uploading reports for the commit 09f6564 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #17727      +/-   ##
==========================================
- Coverage   68.11%   68.11%   -0.01%     
==========================================
  Files        1653     1653              
  Lines       66374    66367       -7     
  Branches     7121     7121              
==========================================
- Hits        45211    45204       -7     
  Misses      19266    19266              
  Partials     1897     1897              
Flag Coverage Δ
javascript 56.24% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-ui-chart-controls/src/components/Tooltip.tsx 90.00% <ø> (-0.91%) ⬇️
...d/packages/superset-ui-chart-controls/src/types.ts 90.47% <ø> (-0.83%) ⬇️
...ntend/packages/superset-ui-core/src/chart/index.ts 100.00% <ø> (ø)
superset-frontend/src/components/Form/Form.tsx 100.00% <ø> (ø)
superset-frontend/src/components/Form/index.tsx 100.00% <ø> (ø)
superset-frontend/src/components/Icons/index.tsx 100.00% <ø> (ø)
...et-frontend/src/components/Select/NativeSelect.tsx 70.00% <ø> (ø)
superset-frontend/src/components/Slider/index.tsx 75.00% <ø> (ø)
superset-frontend/src/components/Switch/index.tsx 100.00% <ø> (ø)
superset-frontend/src/common/components/index.tsx 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 485852d...09f6564. Read the comment docs.

@villebro
Copy link
Member

@stephenLYZ can you add a description to describe the proposed changes. Thanks!

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested to resolve the errors, thanks for cleaning these up!

@zhaoyongjie zhaoyongjie self-requested a review December 15, 2021 07:47
Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 142b5bc into apache:master Dec 15, 2021
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants