Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filter-sets): 404 on dashboard load #17777

Merged
merged 1 commit into from
Dec 16, 2021

Conversation

villebro
Copy link
Member

@villebro villebro commented Dec 16, 2021

SUMMARY

Currently loading a dashboard with the DASHBOARD_NATIVE_FILTER_SETS feature flag enabled triggers a 404 to the filtersets dashboard endpoint. This is most likely due to a race condition which is caused by the dashboard state not being available in Redux yet when the filter set request is dispatched. This adds the dashboard id to the getFilterSets action to ensure that the caller already has the id available.

AFTER

After the change the filter set request results in a 200 with the correct dashboard id:
image

BEFORE

Before the change, loading a dashboard always triggers a 404 to the filter set endpoint:
image

TESTING INSTRUCTIONS

  1. Enable "DASHBOARD_NATIVE_FILTER_SETS" feature flag.
  2. Enter a dashboard
  3. Observe a 404 to the filter set endpoint

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 16, 2021

Codecov Report

Merging #17777 (fceeff3) into master (c18d486) will increase coverage by 0.00%.
The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #17777   +/-   ##
=======================================
  Coverage   67.78%   67.78%           
=======================================
  Files        1605     1605           
  Lines       64200    64199    -1     
  Branches     6790     6790           
=======================================
  Hits        43519    43519           
+ Misses      18825    18824    -1     
  Partials     1856     1856           
Flag Coverage Δ
javascript 54.82% <20.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rontend/src/dashboard/containers/DashboardPage.tsx 26.88% <0.00%> (ø)
...et-frontend/src/dashboard/actions/nativeFilters.ts 44.31% <25.00%> (+0.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c18d486...fceeff3. Read the comment docs.

@villebro villebro merged commit 961766e into apache:master Dec 16, 2021
shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants