Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: close bracket on helm chart reference #17975

Merged
merged 1 commit into from
Jan 10, 2022
Merged

docs: close bracket on helm chart reference #17975

merged 1 commit into from
Jan 10, 2022

Conversation

brnnnfx
Copy link
Contributor

@brnnnfx brnnnfx commented Jan 8, 2022 •
edited
Loading

SUMMARY

This is a minor Markdown change in the README to close brackets on the Helm charts reference so that it will be properly presented as a hyperlink

This is a minor improvement to make the README more polished for readers

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
before

After
after

No tests were created or modified because this is documentation written in Markdown

amitmiran137
amitmiran137 approved these changes Jan 9, 2022
View reviewed changes
Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@brnnnfx brnnnfx changed the title Close bracket on Helm chart reference docs: close bracket on helm chart reference Jan 9, 2022
geido
geido approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@geido geido left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @brnnnfx! I see this is your first PR in Superset, which is great. Let me know if you would like to contribute more, I'd be happy to assist.

@geido geido merged commit 7964465 into apache:master Jan 10, 2022
@brnnnfx brnnnfx deleted the patch-1 branch January 10, 2022 19:07
@brnnnfx
Copy link
Contributor Author

brnnnfx commented Jan 10, 2022

Thank you @brnnnfx! I see this is your first PR in Superset, which is great. Let me know if you would like to contribute more, I'd be happy to assist.

Thanks @geido I would be interested in contributing more!

@geido
Copy link
Member

geido commented Jan 11, 2022

That's great @brnnnfx. If you haven't already, join the Superset Slack. We can chat there. I am geido there too.

shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
@brnnnfx @shcoderAlex
Close bracket on Helm chart reference (apache#17975)
b609159
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@brnnnfx @bwang221
Close bracket on Helm chart reference (apache#17975)
bcce57a
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amitmiran137 amitmiran137 amitmiran137 approved these changes

@geido geido geido approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brnnnfx @geido @amitmiran137 @mistercrunch