Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(DatasourceEditor): Create Datasource Legacy Editor Feature Flag #18003

Merged
merged 19 commits into from
Jan 12, 2022

Conversation

AAfghahi
Copy link
Member

SUMMARY

This creates a new feature flag for the legacy datasource editor that we are going to depreciate in superset 2.0. Currently it is set to False, which will show the legacy datasource editor, but it gives users the option to not have the option available anymore.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@AAfghahi AAfghahi force-pushed the ch33567_legacyDatasourceEditor branch 2 times, most recently from b9a1026 to 369c34f Compare January 11, 2022 20:05
@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #18003 (27f79cd) into master (46715b2) will increase coverage by 0.01%.
The diff coverage is 98.55%.

❗ Current head 27f79cd differs from pull request most recent head 92578d5. Consider uploading reports for the commit 92578d5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18003      +/-   ##
==========================================
+ Coverage   66.30%   66.32%   +0.01%     
==========================================
  Files        1569     1569              
  Lines       61626    61661      +35     
  Branches     6232     6233       +1     
==========================================
+ Hits        40861    40895      +34     
- Misses      19166    19167       +1     
  Partials     1599     1599              
Flag Coverage Δ
javascript 50.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <ø> (ø)
superset/config.py 91.66% <ø> (ø)
superset/connectors/sqla/models.py 88.31% <ø> (ø)
superset/reports/commands/create.py 89.18% <92.30%> (+0.66%) ⬆️
...tend/src/components/Datasource/DatasourceModal.tsx 70.73% <100.00%> (+0.73%) ⬆️
superset/models/reports.py 100.00% <100.00%> (ø)
superset/reports/commands/execute.py 91.51% <100.00%> (+0.22%) ⬆️
superset/reports/notifications/base.py 95.83% <100.00%> (ø)
superset/reports/notifications/email.py 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46715b2...92578d5. Read the comment docs.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! CI might require some love though

@AAfghahi AAfghahi force-pushed the ch33567_legacyDatasourceEditor branch from 369c34f to 92578d5 Compare January 12, 2022 17:07
@AAfghahi
Copy link
Member Author

LGTM! CI might require some love though

Thank you! Just fixed CI issues (crossing fingers)

@AAfghahi AAfghahi merged commit 536ca1f into apache:master Jan 12, 2022
@hughhhh hughhhh self-requested a review January 12, 2022 19:03
@hughhhh
Copy link
Member

hughhhh commented Jan 12, 2022

Approved 🚀

shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
…apache#18003)

* a lot of console logs

* adding new feature flag for datasource editor
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
…apache#18003)

* a lot of console logs

* adding new feature flag for datasource editor
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants