Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Moves the Explore form_data endpoint #18151

Merged
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 0 additions & 35 deletions superset/charts/form_data/commands/create.py

This file was deleted.

37 changes: 0 additions & 37 deletions superset/charts/form_data/commands/delete.py

This file was deleted.

44 changes: 0 additions & 44 deletions superset/charts/form_data/commands/get.py

This file was deleted.

40 changes: 0 additions & 40 deletions superset/charts/form_data/commands/update.py

This file was deleted.

2 changes: 1 addition & 1 deletion superset/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,7 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]:
}

# Cache for chart form data
CHART_FORM_DATA_CACHE_CONFIG: CacheConfig = {
EXPLORE_FORM_DATA_CACHE_CONFIG: CacheConfig = {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change that needs to be flagged in UPDATING.md. Related to this, I've been thinking we should add a config which makes it possible to restrict the cache types that can be used. By restricting to e.g. Redis, we could ensure that the service doesn't start up if the admin has forgotten to add a recently added cache config.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! I'll update the file. I liked the idea of restricting the cache types. I will do it in a separate PR where I'll also improve the cache_manager initialization.

"CACHE_TYPE": "FileSystemCache",
"CACHE_DIR": os.path.join(DATA_DIR, "cache"),
"CACHE_DEFAULT_TIMEOUT": int(timedelta(days=7).total_seconds()),
Expand Down
File renamed without changes.
Loading