fix: Dataset column names are no longer editable #18164
Conversation
…w vertically aligned
|
/testenv up |
|
@hughhhh Container image not yet published for this PR. Please try again when build is complete. |
|
@hughhhh Ephemeral environment creation failed. Please check the Actions logs for details. |
| @@ -78,7 +78,7 @@ describe('DatasourceEditor', () => { | |||
| }); | |||
| userEvent.click(getToggles[0]); | |||
| const getTextboxes = screen.getAllByRole('textbox'); | |||
| expect(getTextboxes.length).toEqual(12); | |||
| expect(getTextboxes.length).toEqual(5); | |||
There was a problem hiding this comment.
The editable names were text boxes.
Codecov Report
@@ Coverage Diff @@
## master #18164 +/- ##
=======================================
Coverage 65.95% 65.95%
=======================================
Files 1584 1584
Lines 62063 62064 +1
Branches 6273 6273
=======================================
+ Hits 40934 40935 +1
Misses 19508 19508
Partials 1621 1621
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
/testenv up |
|
@yousoph Ephemeral environment spinning up at http://34.219.63.217:8080. Credentials are |
| @@ -78,7 +78,7 @@ describe('DatasourceEditor', () => { | |||
| }); | |||
| userEvent.click(getToggles[0]); | |||
| const getTextboxes = screen.getAllByRole('textbox'); | |||
| expect(getTextboxes.length).toEqual(12); | |||
| expect(getTextboxes.length).toEqual(5); | |||
There was a problem hiding this comment.
The editable names were text boxes.
|
Ephemeral environment shutdown and build artifacts deleted. |
…w vertically aligned (apache#18164)
…w vertically aligned (apache#18164)
…w vertically aligned (apache#18164)
mistercrunch
added
🏷️ bot
SUMMARY
The name field in the column field of the edit dataset modal should not be editable.
Bonus: I also vertically-aligned the rows in the calculated columns tab
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
Columns tab:
Calculated columns tab:
AFTER
Columns tab:
Calculated columns tab:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION