Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: upgrade ControlHeader to TSX & FC and add storybook #18188

Merged
merged 3 commits into from
Jan 31, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
174 changes: 0 additions & 174 deletions superset-frontend/src/explore/components/ControlHeader.jsx

This file was deleted.

77 changes: 77 additions & 0 deletions superset-frontend/src/explore/components/ControlHeader.stories.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
/**
ad-m marked this conversation as resolved.
Show resolved Hide resolved
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/
import React from 'react';
import ControlHeader, { ControlHeaderProps } from './ControlHeader';

export default {
title: 'ControlHeader',
component: ControlHeader,
};

const options: {
[key: string]: ControlHeaderProps;
} = {
label: {
label: 'Control label',
},
warning: {
label: 'Control warning',
warning: 'Example of warning message',
},
error: {
label: 'Control error',
validationErrors: ['Something is wrong'],
},
};

export const ControlHeaderGallery = () => (
<>
{Object.entries(options).map(([name, props]) => (
<>
<h4>{name}</h4>
<ControlHeader {...props} />
</>
))}
</>
);

export const InteractiveControlHeader = (props: ControlHeaderProps) => (
<ControlHeader {...props} />
);

InteractiveControlHeader.args = {
label: 'example label',
description: 'example description',
warning: 'example warning',
renderTrigger: false,
hovered: false,
};

InteractiveControlHeader.argTypes = {
tooltipOnClick: { action: 'tooltipOnClick' },
onClick: { action: 'onClick' },
};

InteractiveControlHeader.story = {
parameters: {
knobs: {
disable: true,
},
},
};
Loading