Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added success toasts for database, dataset, chart, dashboard, and query imports #18190

Merged
merged 5 commits into from
Jan 28, 2022
Merged

feat: Added success toasts for database, dataset, chart, dashboard, and query imports #18190

merged 5 commits into from
Jan 28, 2022

Conversation

lyndsiWilliams
Copy link
Member

@lyndsiWilliams lyndsiWilliams commented Jan 27, 2022 •
edited
Loading

SUMMARY

This PR adds success toasts for database, dataset, chart, dashboard, and query imports.

ANIMATED MOV

importToasts.mov

TESTING INSTRUCTIONS

  • Import a database, dataset, chart, dashboard, and query
  • Observe the success toast

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@lyndsiWilliams
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@lyndsiWilliams Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

@lyndsiWilliams Ephemeral environment creation failed. Please check the Actions logs for details.

@lyndsiWilliams lyndsiWilliams changed the title feat: Added success toasts for database, dataset, chart, dashboard, and query imports [WIP]feat: Added success toasts for database, dataset, chart, dashboard, and query imports Jan 27, 2022
@lyndsiWilliams lyndsiWilliams marked this pull request as ready for review January 27, 2022 06:36
@lyndsiWilliams
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@lyndsiWilliams Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

@lyndsiWilliams Ephemeral environment creation failed. Please check the Actions logs for details.

@lyndsiWilliams lyndsiWilliams marked this pull request as draft January 27, 2022 06:49
@codecov
Copy link

codecov bot commented Jan 27, 2022 •
edited
Loading

Codecov Report

Merging #18190 (5c7bd15) into master (e6bb0fc) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18190   +/-   ##
=======================================
  Coverage   66.04%   66.04%           
=======================================
  Files        1591     1591           
  Lines       62415    62421    +6     
  Branches     6285     6290    +5     
=======================================
+ Hits        41224    41228    +4     
- Misses      19569    19571    +2     
  Partials     1622     1622
Flag Coverage Δ
javascript 50.86% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/components/ImportModal/index.tsx 72.50% <ø> (-0.34%) ⬇️
...perset-frontend/src/views/CRUD/chart/ChartList.tsx 56.03% <0.00%> (-0.49%) ⬇️
...rontend/src/views/CRUD/dashboard/DashboardList.tsx 55.14% <0.00%> (-0.53%) ⬇️
...tend/src/views/CRUD/data/database/DatabaseList.tsx 65.47% <0.00%> (-0.79%) ⬇️
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 55.63% <0.00%> (-0.43%) ⬇️
.../src/views/CRUD/data/savedquery/SavedQueryList.tsx 63.88% <0.00%> (-0.60%) ⬇️
...c/filters/components/Select/SelectFilterPlugin.tsx 68.42% <0.00%> (-0.60%) ⬇️
superset-frontend/src/setup/setupPlugins.ts 100.00% <0.00%> (ø)
...d/plugins/plugin-chart-echarts/src/utils/series.ts 92.95% <0.00%> (ø)
...ashboard/components/UndoRedoKeyListeners/index.jsx 100.00% <0.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6bb0fc...5c7bd15. Read the comment docs.

@lyndsiWilliams
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@lyndsiWilliams Ephemeral environment spinning up at http://34.208.178.168:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@lyndsiWilliams
Copy link
Member Author

/testenv up VERSIONED_EXPORT=True

@github-actions
Copy link
Contributor

@lyndsiWilliams Ephemeral environment spinning up at http://52.11.201.248:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@lyndsiWilliams lyndsiWilliams changed the title [WIP]feat: Added success toasts for database, dataset, chart, dashboard, and query imports feat: Added success toasts for database, dataset, chart, dashboard, and query imports Jan 28, 2022
@lyndsiWilliams lyndsiWilliams marked this pull request as ready for review January 28, 2022 14:05
betodealmeida
betodealmeida approved these changes Jan 28, 2022
View reviewed changes
Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we need to make the strings translatable.

@lyndsiWilliams
Copy link
Member Author

Looks good, but we need to make the strings translatable.

Oops, good catch! Thank you! 😬

Fixed in this commit.

@lyndsiWilliams lyndsiWilliams merged commit c40b337 into apache:master Jan 28, 2022
@lyndsiWilliams lyndsiWilliams deleted the lyndsi/import-system-feedback branch January 28, 2022 21:29
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
@lyndsiWilliams @shcoderAlex
feat: Added success toasts for database, dataset, chart, dashboard, a…
9ca633b 
…nd query imports (apache#18190)

* Added imports toasts

* Removed generic import toast

* Remove addSuccessToast from props

* Added addSuccessToast back to prop type

* Made success toast strings translatable
ofekisr pushed a commit to nielsen-oss/superset that referenced this pull request Feb 8, 2022
@lyndsiWilliams @ofekisr
feat: Added success toasts for database, dataset, chart, dashboard, a…
c198b39 
…nd query imports (apache#18190)

* Added imports toasts

* Removed generic import toast

* Remove addSuccessToast from props

* Added addSuccessToast back to prop type

* Made success toast strings translatable
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@lyndsiWilliams @bwang221
feat: Added success toasts for database, dataset, chart, dashboard, a…
5b23c05 
…nd query imports (apache#18190)

* Added imports toasts

* Removed generic import toast

* Remove addSuccessToast from props

* Added addSuccessToast back to prop type

* Made success toast strings translatable
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

@AAfghahi AAfghahi AAfghahi approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lyndsiWilliams @betodealmeida @AAfghahi @mistercrunch