Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alert): remove extra < character in email report #18224

Merged

Conversation

graceguo-supercat
Copy link

@graceguo-supercat graceguo-supercat commented Jan 29, 2022

SUMMARY

Remove extra < character in the alert email.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen_Shot_2022-01-28_at_11_24_30_PM

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Jan 29, 2022

Codecov Report

Merging #18224 (7d4dddd) into master (c40b337) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18224   +/-   ##
=======================================
  Coverage   66.30%   66.30%           
=======================================
  Files        1592     1592           
  Lines       62437    62437           
  Branches     6292     6292           
=======================================
  Hits        41401    41401           
  Misses      19383    19383           
  Partials     1653     1653           
Flag Coverage Δ
hive 52.16% <ø> (ø)
mysql 81.27% <ø> (ø)
postgres 81.32% <ø> (ø)
presto 52.01% <ø> (ø)
python 81.76% <ø> (ø)
sqlite 81.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/reports/notifications/email.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c40b337...7d4dddd. Read the comment docs.

@graceguo-supercat graceguo-supercat merged commit 987237b into apache:master Jan 31, 2022
mega-mo added a commit to Mediaoptimise/superset that referenced this pull request Feb 1, 2022
fix: remove extra < character in email report (apache#18224)
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Feb 7, 2022
@sadpandajoe
Copy link
Member

🏷️ preset:2022.5

shcoderAlex pushed a commit to casual-precision/superset that referenced this pull request Feb 7, 2022
ofekisr pushed a commit to nielsen-oss/superset that referenced this pull request Feb 8, 2022
bwang221 pushed a commit to casual-precision/superset that referenced this pull request Feb 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.5 size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants