Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unify usages of nvd3 library #18828

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

Background: According to bundle analysis, we use both nvd3 and nvd3-fork. We should probably just use nvd3-fork to unify this.
Currently only Nightingale Rose Chart is using nvd3, we remove it here.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch; LGTM 👍

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #18828 (10e7fe6) into master (3c17c60) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18828   +/-   ##
=======================================
  Coverage   66.31%   66.31%           
=======================================
  Files        1620     1620           
  Lines       63096    63096           
  Branches     6375     6375           
=======================================
  Hits        41845    41845           
  Misses      19592    19592           
  Partials     1659     1659           
Flag Coverage Δ
javascript 51.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntend/plugins/legacy-plugin-chart-rose/src/Rose.js 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c17c60...10e7fe6. Read the comment docs.

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kgabryje kgabryje merged commit c491829 into apache:master Feb 21, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants