Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Metadata browser in SQL not render nicely in Safari #18855

Merged

Conversation

codemaster08240328
Copy link
Contributor

SUMMARY

Metadata in SQL Lab doesn't render nicely in safari browser.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

image

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #18855 (35a797f) into master (4c16586) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18855   +/-   ##
=======================================
  Coverage   66.36%   66.36%           
=======================================
  Files        1620     1621    +1     
  Lines       63045    63058   +13     
  Branches     6377     6382    +5     
=======================================
+ Hits        41842    41851    +9     
- Misses      19544    19547    +3     
- Partials     1659     1660    +1     
Flag Coverage Δ
javascript 51.25% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/src/SqlLab/components/ColumnElement/index.tsx 93.75% <100.00%> (+0.41%) ⬆️
...board/components/nativeFilters/FilterBar/index.tsx 66.94% <0.00%> (-2.88%) ⬇️
...d/components/DashboardBuilder/DashboardBuilder.tsx 72.72% <0.00%> (-2.57%) ⬇️
superset-frontend/src/dashboard/constants.ts 100.00% <0.00%> (ø)
superset-frontend/src/components/Button/index.tsx 100.00% <0.00%> (ø)
...ts/nativeFilters/FilterBar/ActionButtons/index.tsx 85.71% <0.00%> (ø)
superset-frontend/src/utils/common.js 89.47% <0.00%> (+0.18%) ⬆️
...ilters/FilterBar/FilterControls/FilterControls.tsx 77.77% <0.00%> (+0.63%) ⬆️
...nents/nativeFilters/FilterBar/FilterSets/index.tsx 37.66% <0.00%> (+0.82%) ⬆️
...omponents/nativeFilters/FilterBar/Header/index.tsx 100.00% <0.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c16586...35a797f. Read the comment docs.

@rusackas rusackas changed the title fix Metadata browser in SQL not render nicely in Safari fix: Metadata browser in SQL not render nicely in Safari Feb 24, 2022
@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://54.189.203.116:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@srinify
Copy link
Contributor

srinify commented Feb 24, 2022

Tested this, looks great! Thanks @codemaster08240328

@rusackas rusackas merged commit 0db49b1 into apache:master Feb 25, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

villebro pushed a commit that referenced this pull request Apr 3, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants