Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Import API): update function description, overwrite real meaning #18882

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

michael-hoffman-26
Copy link
Contributor

SUMMARY

updating the description of model/import function.
the overwrite argument determine whether overwrite the model or not.
before it was written that the overwrite arg determine weather overwrite the database which isn't what actually happened

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #18882 (5a46cf1) into master (0edb979) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18882      +/-   ##
==========================================
- Coverage   66.36%   66.34%   -0.03%     
==========================================
  Files        1621     1621              
  Lines       63058    63057       -1     
  Branches     6382     6382              
==========================================
- Hits        41851    41837      -14     
- Misses      19547    19560      +13     
  Partials     1660     1660              
Flag Coverage Δ
hive 52.28% <ø> (ø)
mysql ?
postgres 81.60% <ø> (ø)
presto 52.12% <ø> (ø)
python 81.99% <ø> (-0.05%) ⬇️
sqlite 81.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/charts/api.py 85.93% <ø> (ø)
superset/dashboards/api.py 92.54% <ø> (ø)
superset/common/utils/dataframe_utils.py 85.71% <0.00%> (-7.15%) ⬇️
superset/db_engine_specs/mysql.py 93.97% <0.00%> (-3.62%) ⬇️
superset/models/core.py 88.19% <0.00%> (-0.73%) ⬇️
superset/views/core.py 77.06% <0.00%> (-0.45%) ⬇️
...board/components/nativeFilters/FilterBar/index.tsx 66.94% <0.00%> (-0.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0edb979...5a46cf1. Read the comment docs.

Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amitmiran137 amitmiran137 merged commit 2c86d1a into apache:master Feb 23, 2022
@amitmiran137 amitmiran137 deleted the dacs-update-api-description branch February 23, 2022 18:54
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.5.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants