Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding Dutch language translations (NL) #18965

Merged
merged 3 commits into from
Mar 7, 2022

Conversation

pablo-guerra
Copy link
Contributor

@pablo-guerra pablo-guerra commented Feb 28, 2022

chore: adding Dutch language translations (NL)

SUMMARY

Added .po and .json files for Dutch translations.
Added Dutch to the list of languages in the config.py file.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image
image

TESTING INSTRUCTIONS

The Dutch language can be enabled and tested by adding the following parameter to the values.yaml file:

LANGUAGES = {
    'en': {'flag': 'us', 'name': 'English'},
    'nl': {'flag': 'nl', 'name': 'Dutch'},
}

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro
Copy link
Member

This is great @pablo-guerra ! Let's see if we can find a fellow person from the Netherlands to review - if not, I'm cool merging as-is if there's nothing obvious out of place.

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #18965 (2ef81da) into master (79633ce) will decrease coverage by 0.19%.
The diff coverage is 64.04%.

❗ Current head 2ef81da differs from pull request most recent head 0d24d86. Consider uploading reports for the commit 0d24d86 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18965      +/-   ##
==========================================
- Coverage   66.38%   66.18%   -0.20%     
==========================================
  Files        1641     1641              
  Lines       63515    63476      -39     
  Branches     6418     6418              
==========================================
- Hits        42165    42013     -152     
- Misses      19690    19803     +113     
  Partials     1660     1660              
Flag Coverage Δ
hive ?
mysql 81.81% <90.24%> (+<0.01%) ⬆️
postgres 81.86% <90.24%> (+<0.01%) ⬆️
presto ?
python 81.90% <90.24%> (-0.39%) ⬇️
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-ui-chart-controls/src/sections/sections.tsx 100.00% <ø> (ø)
...chart-controls/src/shared-controls/dndControls.tsx 35.89% <ø> (ø)
...et-ui-chart-controls/src/shared-controls/index.tsx 36.00% <ø> (ø)
...perset-ui-chart-controls/src/utils/D3Formatting.ts 100.00% <ø> (ø)
...perset-ui-core/src/chart/components/SuperChart.tsx 100.00% <ø> (ø)
...ckages/superset-ui-core/src/query/extractExtras.ts 100.00% <ø> (ø)
...ackages/superset-ui-core/src/query/types/Column.ts 100.00% <ø> (ø)
.../superset-ui-core/src/query/types/QueryFormData.ts 100.00% <ø> (ø)
...reset-chart-deckgl/src/utilities/Shared_DeckGL.jsx 84.21% <ø> (ø)
...acy-preset-chart-deckgl/src/utilities/controls.jsx 20.00% <ø> (ø)
... and 252 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79633ce...0d24d86. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🇳🇱

@villebro villebro merged commit 4467503 into apache:master Mar 7, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
* added NL translations

* added Dutch to config

* fixed end of line on .po file

Co-authored-by: pablo.guerra-at-026399402087 <pablo.guerra@026399402087>
(cherry picked from commit 4467503)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 size/XXL 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants