Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unnecessary divider #19048

Merged
merged 2 commits into from
Mar 8, 2022
Merged

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Mar 7, 2022

SUMMARY

This pr removes the divider that is no longer need in the data dropdown menu.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before
Screen Shot 2022-03-07 at 1 39 59 PM

after
Screen Shot 2022-03-07 at 1 37 35 PM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #19048 (9adb7b3) into master (1b7d056) will increase coverage by 0.19%.
The diff coverage is 100.00%.

❗ Current head 9adb7b3 differs from pull request most recent head 536c480. Consider uploading reports for the commit 536c480 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #19048      +/-   ##
==========================================
+ Coverage   66.33%   66.52%   +0.19%     
==========================================
  Files        1641     1641              
  Lines       63476    63476              
  Branches     6444     6444              
==========================================
+ Hits        42106    42229     +123     
+ Misses      19704    19584     -120     
+ Partials     1666     1663       -3     
Flag Coverage Δ
javascript 51.29% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/components/Menu.tsx 58.97% <100.00%> (+2.56%) ⬆️
superset/db_engine_specs/base.py 89.48% <0.00%> (+0.33%) ⬆️
superset/reports/commands/execute.py 91.51% <0.00%> (+0.36%) ⬆️
superset/views/base_api.py 97.89% <0.00%> (+0.42%) ⬆️
superset/views/core.py 77.47% <0.00%> (+0.44%) ⬆️
superset/connectors/sqla/models.py 90.11% <0.00%> (+0.47%) ⬆️
superset/common/query_object.py 95.67% <0.00%> (+0.54%) ⬆️
superset/views/database/views.py 91.89% <0.00%> (+1.35%) ⬆️
superset/models/core.py 88.91% <0.00%> (+1.44%) ⬆️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 64.67% <0.00%> (+1.63%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b7d056...536c480. Read the comment docs.

@pkdotson pkdotson merged commit 4d96393 into apache:master Mar 8, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
* fix: remove unnecessary divider

* remove console

(cherry picked from commit 4d96393)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset-io size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants