feat(ui): Adding manifest prefix config #19141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
approved these changes
Mar 14, 2022
Comment on lines
+79
to
+80
| for f in filtered_files: | ||
| loaded_chunks.add(f) |
There was a problem hiding this comment.
No need to do this (specially if CI is green) but this can be simplified:
Suggested change
| for f in filtered_files: | |
| loaded_chunks.add(f) | |
| loaded_chunks.update(filtered_files) |
Codecov Report
@@ Coverage Diff @@
## master #19141 +/- ##
==========================================
- Coverage 66.54% 66.40% -0.15%
==========================================
Files 1646 1646
Lines 63630 63633 +3
Branches 6475 6475
==========================================
- Hits 42343 42254 -89
- Misses 19607 19699 +92
Partials 1680 1680
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
…prefix # Conflicts: # superset/utils/async_query_manager.py
…prefix # Conflicts: # superset-frontend/src/components/TimezoneSelector/TimezoneSelector.test.tsx
dpgaspar
approved these changes
Mar 16, 2022
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 17, 2022
* Adding manifest prefix config * Fixing broken tests * Fixing import * Adding prefix for remaining assets * Changing static prefix strategy * Fixing DST test * Fixing up formatting * Fixing up async_query_manager.py types (cherry picked from commit 4b34817)
|
🏷️ preset:2022.11 |
villebro
pushed a commit
that referenced
this pull request
Apr 3, 2022
* Adding manifest prefix config * Fixing broken tests * Fixing import * Adding prefix for remaining assets * Changing static prefix strategy * Fixing DST test * Fixing up formatting * Fixing up async_query_manager.py types
mistercrunch
added
🍒 1.5.0
🍒 1.5.1
🍒 1.5.2
🍒 1.5.3
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
STATIC_ASSETS_PREFIXwhich allows for a custom URL prefix to be added to assets included in the app during manifest processingsuperset.typing->superset.superset_typingin order to avoid circular import issues with some python variants/IDEs