Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql lab): most recently selected table should appear at the top of the list on the left panel #19258

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

When adding a new table in the SQL Tab, it should appear at the top, since it's the most recent.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2022-03-18.at.12.53.02.mov

After:

Screen.Recording.2022-03-18.at.12.51.33.mov

TESTING INSTRUCTIONS

  1. Go to SQL Lab
  2. Select a DB
  3. Select a Schema
  4. Select tables

Ensure the tables are added at the top.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #19258 (8f6d3ee) into master (e7355b9) will increase coverage by 0.00%.
The diff coverage is 94.73%.

❗ Current head 8f6d3ee differs from pull request most recent head cf91285. Consider uploading reports for the commit cf91285 to get more accurate results

@@           Coverage Diff           @@
##           master   #19258   +/-   ##
=======================================
  Coverage   66.77%   66.78%           
=======================================
  Files        1670     1670           
  Lines       64385    64401   +16     
  Branches     6501     6501           
=======================================
+ Hits        42994    43009   +15     
- Misses      19707    19708    +1     
  Partials     1684     1684           
Flag Coverage Δ
javascript 51.33% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.82% <ø> (ø)
superset/connectors/sqla/utils.py 91.66% <90.00%> (-0.50%) ⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js 60.73% <100.00%> (ø)
superset-frontend/src/SqlLab/reducers/sqlLab.js 33.15% <100.00%> (ø)
superset/connectors/sqla/models.py 90.17% <100.00%> (+0.05%) ⬆️
superset/errors.py 94.44% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7355b9...cf91285. Read the comment docs.

@diegomedina248 diegomedina248 force-pushed the fix/most-recently-selected-table-should-appear-at-the-top-of-the-list-on-the-left-panel branch from 68c018e to cf91285 Compare March 18, 2022 17:53
Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit 4669b6c into apache:master Mar 21, 2022
michael-hoffman-26 pushed a commit to nielsen-oss/superset that referenced this pull request Mar 23, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 Preset-Patch size/S 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants