Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default toast position #19296

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

suddjian
Copy link
Member

SUMMARY

a typo

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for fixing

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #19296 (a85b8f7) into master (f9feb1b) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #19296   +/-   ##
=======================================
  Coverage   66.64%   66.64%           
=======================================
  Files        1670     1670           
  Lines       64590    64590           
  Branches     6506     6506           
=======================================
  Hits        43047    43047           
  Misses      19860    19860           
  Partials     1683     1683           
Flag Coverage Δ
javascript 51.39% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nd/src/components/MessageToasts/ToastPresenter.tsx 93.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9feb1b...a85b8f7. Read the comment docs.

@rusackas
Copy link
Member

Before:
image

After:
image

@villebro
Copy link
Member

Tagging PR with the regression: #19144

@villebro villebro merged commit 35b8a72 into apache:master Mar 22, 2022
@sadpandajoe
Copy link
Member

🏷️ preset:2022.11

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Mar 22, 2022
michael-hoffman-26 pushed a commit to nielsen-oss/superset that referenced this pull request Mar 23, 2022
villebro pushed a commit that referenced this pull request Apr 3, 2022
(cherry picked from commit 35b8a72)
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset:2022.11 preset-io size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants