Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sql lab): increase the size of the action icons in the history tab #19313

Merged

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

This PR increases the size of the action icons in the SQL Lab history tab to match the rest of the application.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2022-03-22 at 14 45 03

After:
Screen Shot 2022-03-22 at 14 44 15

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #19313 (eea68a5) into master (2de5e6f) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head eea68a5 differs from pull request most recent head 46bd9f2. Consider uploading reports for the commit 46bd9f2 to get more accurate results

@@            Coverage Diff             @@
##           master   #19313      +/-   ##
==========================================
- Coverage   66.66%   66.65%   -0.01%     
==========================================
  Files        1678     1680       +2     
  Lines       64261    64270       +9     
  Branches     6561     6561              
==========================================
  Hits        42837    42837              
- Misses      19723    19732       +9     
  Partials     1701     1701              
Flag Coverage Δ
javascript 51.44% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../legacy-plugin-chart-country-map/src/CountryMap.js 0.00% <ø> (ø)
...y-plugin-chart-country-map/src/ReactCountryMap.jsx 0.00% <0.00%> (ø)
...y-plugin-chart-sankey-loop/src/ReactSankeyLoop.jsx 0.00% <0.00%> (ø)
.../legacy-plugin-chart-sankey-loop/src/SankeyLoop.js 0.00% <ø> (ø)
...lugin-chart-echarts/src/BigNumber/BigNumberViz.tsx 0.00% <0.00%> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js 60.39% <0.00%> (-0.35%) ⬇️
...rontend/src/SqlLab/components/QueryTable/index.tsx 68.96% <ø> (ø)
superset/models/sql_lab.py 91.55% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4baa82...46bd9f2. Read the comment docs.

@rusackas
Copy link
Member

rusackas commented Apr 6, 2022

This just needs conflict resolution, and it should be all set!

@diegomedina248 diegomedina248 force-pushed the fix/sql-lab-history-action-icons-size branch from a22b0f6 to 46bd9f2 Compare April 6, 2022 10:48
@diegomedina248
Copy link
Contributor Author

@rusackas updated 👍

@rusackas rusackas merged commit c6c9188 into apache:master Apr 6, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants