Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): make to hide the delete button of most recent query history #19358

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented Mar 24, 2022

SUMMARY

Hide Delete Action on Most Recently Run Query

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
After deleting the most recently query, clear the result tab.
image
image

AFTER:
The result tab is not cleared by hiding the delete action on Most recent run query
image

TESTING INSTRUCTIONS

How to reproduce the issue

  1. In SQL Lab, run 2 queries
  2. In the query history tab of SQL Lab, delete the most recent query
  3. Deleting the most recent query also clears your query results tab
  4. Should not clear query results tab.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #19358 (1e73c29) into master (3313530) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master   #19358   +/-   ##
=======================================
  Coverage   66.65%   66.65%           
=======================================
  Files        1675     1675           
  Lines       64654    64655    +1     
  Branches     6503     6504    +1     
=======================================
+ Hits        43092    43093    +1     
  Misses      19876    19876           
  Partials     1686     1686           
Flag Coverage Δ
javascript 51.31% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/SqlLab/components/SouthPane/index.tsx 64.51% <ø> (ø)
...rontend/src/SqlLab/components/QueryTable/index.tsx 68.96% <50.00%> (+0.54%) ⬆️
...ntend/src/SqlLab/components/QueryHistory/index.tsx 66.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3313530...1e73c29. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the description/screenshots/testing steps!

@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://34.218.74.27:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas rusackas merged commit 5db36ec into apache:master Apr 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2022

Ephemeral environment shutdown and build artifacts deleted.

philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/S 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants