-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sqllab): make to hide the delete button of most recent query history #19358
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19358 +/- ##
=======================================
Coverage 66.65% 66.65%
=======================================
Files 1675 1675
Lines 64654 64655 +1
Branches 6503 6504 +1
=======================================
+ Hits 43092 43093 +1
Misses 19876 19876
Partials 1686 1686
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the description/screenshots/testing steps!
/testenv up |
@rusackas Ephemeral environment spinning up at http://34.218.74.27:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Hide Delete Action on Most Recently Run Query
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
After deleting the most recently query, clear the result tab.
AFTER:
The result tab is not cleared by hiding the delete action on Most recent run query
TESTING INSTRUCTIONS
How to reproduce the issue
ADDITIONAL INFORMATION