Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add support for npm8 #19365

Merged
merged 1 commit into from
Mar 25, 2022
Merged

chore: add support for npm8 #19365

merged 1 commit into from
Mar 25, 2022

Conversation

villebro
Copy link
Member

@villebro villebro commented Mar 25, 2022

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Since npm@8 is nowadays the default on Node LTS (16 at the time of writing), we should add support for it to get rid of this warning (both locally and on CI) when building frontend assets. Here I've arbitrarily chosen ^8.1.2 as that's what I currently have, but 7.x || 8.x would probably work equally well.

BEFORE

Currently this warning is displayed when building with npm@8
image

AFTER

With this PR the warning no longer appears:
image

TESTING INSTRUCTIONS

CI

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #19365 (8e8a0fa) into master (45c28c8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19365   +/-   ##
=======================================
  Coverage   66.67%   66.67%           
=======================================
  Files        1676     1676           
  Lines       64714    64714           
  Branches     6506     6506           
=======================================
  Hits        43150    43150           
  Misses      19878    19878           
  Partials     1686     1686           
Flag Coverage Δ
javascript 51.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45c28c8...8e8a0fa. Read the comment docs.

@villebro villebro merged commit 6141a9a into apache:master Mar 25, 2022
@villebro villebro deleted the villebro/npm8 branch March 25, 2022 09:07
villebro added a commit that referenced this pull request Apr 3, 2022
(cherry picked from commit 6141a9a)
@rusackas rusackas mentioned this pull request Apr 14, 2022
9 tasks
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels lts-v1 preset-io size/XS 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants