-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Removes the CSS files from the Partition plugin #19521
Merged
michael-s-molina
merged 3 commits into
apache:master
from
michael-s-molina:partition-to-emotion
Apr 7, 2022
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 0 additions & 64 deletions
64
superset-frontend/plugins/legacy-plugin-chart-partition/src/Partition.css
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 0 additions & 22 deletions
22
superset-frontend/plugins/legacy-plugin-chart-partition/src/ReactPartition.js
This file was deleted.
Oops, something went wrong.
81 changes: 81 additions & 0 deletions
81
superset-frontend/plugins/legacy-plugin-chart-partition/src/ReactPartition.jsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, | ||
| * software distributed under the License is distributed on an | ||
| * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| * KIND, either express or implied. See the License for the | ||
| * specific language governing permissions and limitations | ||
| * under the License. | ||
| */ | ||
| import React from 'react'; | ||
| import { reactify, styled } from '@superset-ui/core'; | ||
| import Component from './Partition'; | ||
|
|
||
| const ReactComponent = reactify(Component); | ||
|
|
||
| const Partition = ({ className, ...otherProps }) => ( | ||
| <div className={className}> | ||
| <ReactComponent {...otherProps} /> | ||
| </div> | ||
| ); | ||
|
|
||
| export default styled(Partition)` | ||
| ${({ theme }) => ` | ||
| .superset-legacy-chart-partition { | ||
| position: relative; | ||
| } | ||
|
|
||
| .superset-legacy-chart-partition .chart { | ||
| display: block; | ||
| margin: auto; | ||
| font-size: ${theme.typography.sizes.s}px; | ||
| } | ||
|
|
||
| .superset-legacy-chart-partition rect { | ||
| stroke: ${theme.colors.grayscale.light2}; | ||
| fill: ${theme.colors.grayscale.light1}; | ||
| fill-opacity: ${theme.opacity.heavy}; | ||
| transition: fill-opacity 180ms linear; | ||
| cursor: pointer; | ||
| } | ||
|
|
||
| .superset-legacy-chart-partition rect:hover { | ||
| fill-opacity: 1; | ||
| } | ||
|
|
||
| .superset-legacy-chart-partition g text { | ||
| font-weight: ${theme.typography.weights.bold}; | ||
| fill: ${theme.colors.grayscale.dark1}; | ||
| } | ||
|
|
||
| .superset-legacy-chart-partition g:hover text { | ||
| fill: ${theme.colors.grayscale.dark2}; | ||
| } | ||
|
|
||
| .superset-legacy-chart-partition .partition-tooltip { | ||
| position: absolute; | ||
| top: 0; | ||
| left: 0; | ||
| opacity: 0; | ||
| padding: ${theme.gridUnit}px; | ||
| pointer-events: none; | ||
| background-color: ${theme.colors.grayscale.dark2}; | ||
| border-radius: ${theme.gridUnit}px; | ||
| } | ||
|
|
||
| .partition-tooltip td { | ||
| padding-left: ${theme.gridUnit}px; | ||
| font-size: ${theme.typography.sizes.s}px; | ||
| color: ${theme.colors.grayscale.light5}; | ||
| } | ||
| `} | ||
| `; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michael-s-molina should we use the available white from the theme vars?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch! I removed the condition and used the transparent border to always show the partition's colors. Previously, when the user was hovering over a partition, the leaf was white. Now the leaf obeys the color of the partition. I think it's more intuitive.