Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix grammar error #19740

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Apr 16, 2022

SUMMARY

rename isValidTimeCompare => isTimeComparison

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie changed the title fix: get rid of drop level when time comparison fix: get rid of drop level when time comparison is actual values Apr 16, 2022
@zhaoyongjie zhaoyongjie requested a review from a team April 16, 2022 08:35
export const isValidTimeCompare: PostProcessingFactory<boolean> = (
export const isTimeComparison: PostProcessingFactory<boolean> = (
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bycatch: grammar error.

@codecov
Copy link

codecov bot commented Apr 16, 2022

Codecov Report

Merging #19740 (54c89cd) into master (3c28cd4) will not change coverage.
The diff coverage is 75.00%.

❗ Current head 54c89cd differs from pull request most recent head a6ec683. Consider uploading reports for the commit a6ec683 to get more accurate results

@@           Coverage Diff           @@
##           master   #19740   +/-   ##
=======================================
  Coverage   66.53%   66.53%           
=======================================
  Files        1692     1692           
  Lines       64777    64777           
  Branches     6660     6660           
=======================================
  Hits        43101    43101           
  Misses      19977    19977           
  Partials     1699     1699           
Flag Coverage Δ
javascript 51.23% <75.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ui-chart-controls/src/operators/flattenOperator.ts 100.00% <ø> (ø)
.../plugin-chart-echarts/src/Timeseries/buildQuery.ts 66.66% <0.00%> (ø)
...-ui-chart-controls/src/operators/renameOperator.ts 100.00% <100.00%> (ø)
...rt-controls/src/operators/rollingWindowOperator.ts 100.00% <100.00%> (ø)
...hart-controls/src/operators/timeCompareOperator.ts 100.00% <100.00%> (ø)
...controls/src/operators/timeComparePivotOperator.ts 100.00% <100.00%> (ø)
...t-controls/src/operators/utils/isTimeComparison.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c28cd4...a6ec683. Read the comment docs.

@zhaoyongjie zhaoyongjie changed the title fix: get rid of drop level when time comparison is actual values fix: duplicate seriese name when time comparison is actual values Apr 18, 2022
@zhaoyongjie zhaoyongjie changed the title fix: duplicate seriese name when time comparison is actual values fix: duplicate series name when time comparison is actual values Apr 18, 2022
@zhaoyongjie zhaoyongjie marked this pull request as draft April 20, 2022 09:46
@pull-request-size pull-request-size bot added size/S and removed size/M labels Apr 20, 2022
@zhaoyongjie zhaoyongjie changed the title fix: duplicate series name when time comparison is actual values chore: fix grammar error Apr 20, 2022
@zhaoyongjie zhaoyongjie marked this pull request as ready for review April 20, 2022 12:07
@zhaoyongjie zhaoyongjie merged commit 4f997cd into apache:master Apr 20, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants