Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): Double divider if no permissions for adding reports #19777

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

kgabryje
Copy link
Member

SUMMARY

Fix displaying double divider in actions menu in explore if user doesn't have permissions for managing reports

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

  1. Log in as a user without reports permissions
  2. Verify that there is only 1 divider between "Share" and "View query" in actions dropdown in explore

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CC @kasiazjc

@kasiazjc
Copy link
Contributor

Thanks! LGTM

@kasiazjc
Copy link
Contributor

Thanks! LGTM

Are there any other cases in which double divider can appear (for example cannot edit properties) and are they all covered by this change? @kgabryje

@kgabryje
Copy link
Member Author

Other cases were covered

@codecov
Copy link

codecov bot commented Apr 19, 2022

Codecov Report

Merging #19777 (a7da034) into master (6f4480a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #19777   +/-   ##
=======================================
  Coverage   66.51%   66.51%           
=======================================
  Files        1690     1690           
  Lines       64616    64616           
  Branches     6656     6656           
=======================================
  Hits        42978    42978           
  Misses      19937    19937           
  Partials     1701     1701           
Flag Coverage Δ
javascript 51.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../components/ExploreAdditionalActionsMenu/index.jsx 57.14% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f4480a...a7da034. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgabryje kgabryje merged commit 3663a33 into apache:master Apr 19, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants