Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: have user go to explore after dataset creation #19965

Merged
merged 9 commits into from
Jul 12, 2022

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented May 5, 2022

SUMMARY

This pr creates a new flow from the dataset modal where after user creates a datasource it directs them to the explore page.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after

Screen.Recording.2022-05-10.at.12.09.41.PM.mov

TESTING INSTRUCTIONS

Go to create dataset and save. It should direct you to explore page.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #19965 (a2cede3) into master (7f918a4) will decrease coverage by 0.00%.
The diff coverage is 10.00%.

@@            Coverage Diff             @@
##           master   #19965      +/-   ##
==========================================
- Coverage   66.85%   66.85%   -0.01%     
==========================================
  Files        1753     1753              
  Lines       65827    65835       +8     
  Branches     7006     7007       +1     
==========================================
+ Hits        44010    44011       +1     
- Misses      20031    20037       +6     
- Partials     1786     1787       +1     
Flag Coverage Δ
javascript 51.94% <10.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/addSlice/App.tsx 0.00% <0.00%> (ø)
...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx 42.50% <0.00%> (ø)
...perset-frontend/src/addSlice/AddSliceContainer.tsx 59.61% <14.28%> (-7.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f918a4...a2cede3. Read the comment docs.

@yousoph
Copy link
Member

yousoph commented May 5, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2022

@yousoph Ephemeral environment spinning up at http://34.217.36.72:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@pull-request-size pull-request-size bot added size/S and removed size/XS labels May 6, 2022
@yousoph
Copy link
Member

yousoph commented May 9, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2022

@yousoph Ephemeral environment spinning up at http://34.222.46.113:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@yousoph
Copy link
Member

yousoph commented May 20, 2022

/testenv up

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://34.216.189.219:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@yousoph
Copy link
Member

yousoph commented May 20, 2022

Two things I noticed:

  1. In the add chart flow, the dataset in the dropdown isn't styled the same way as if you had selected the dataset manually
    image

  2. I think it would be smoother to bring the user directly to the create chart flow without the user seeing the dataset CRUD view in between, if we can do that. The dataset created confirmation toast could appear on the create chart page (instead of on the CRUD view)

cc @jess-dillard if you want to test on the ephemeral & for feedback on point 2

@ghost
Copy link

ghost commented May 20, 2022

Agreed with @yousoph, let's make those changes.

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 8, 2022
@pkdotson pkdotson merged commit c795dc2 into apache:master Jul 12, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants