Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert chore(deps): bump d3-svg-legend in /superset-frontend (#19846) #19972

Merged
merged 1 commit into from
May 6, 2022

Conversation

villebro
Copy link
Member

@villebro villebro commented May 6, 2022

SUMMARY

d3-svg-legend version 2 is incompatible with d3 version 3 (see: susielu/d3-legend#58), causing the Heatmap chart to fail to render. I contemplated the option of bumping d3 to version 4, but decided against it due to the following reasons:

  • The API has been totally overhauled in d3 version 4 and would have required fairly big changes
  • d3 is now on version 7
  • d3-svg-legend has been stale for 4 years

Instead I think we should just migrate this plugin to d3 version 7 or the equivalent ECharts version (https://echarts.apache.org/examples/en/editor.html?c=heatmap-cartesian) while migrating this plugin to the v1 chart data endpoint.

Related PR: #19846

AFTER

image

BEFORE

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro changed the title Revert "chore(deps): bump d3-svg-legend in /superset-frontend (#19846)" revert: chore(deps): bump d3-svg-legend in /superset-frontend (#19846) May 6, 2022
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #19972 (127754c) into master (7b5ba39) will not change coverage.
The diff coverage is n/a.

❗ Current head 127754c differs from pull request most recent head fe713c8. Consider uploading reports for the commit fe713c8 to get more accurate results

@@           Coverage Diff           @@
##           master   #19972   +/-   ##
=======================================
  Coverage   66.29%   66.29%           
=======================================
  Files        1712     1712           
  Lines       63962    63962           
  Branches     6731     6731           
=======================================
  Hits        42404    42404           
  Misses      19847    19847           
  Partials     1711     1711           
Flag Coverage Δ
javascript 51.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b5ba39...fe713c8. Read the comment docs.

@villebro villebro changed the title revert: chore(deps): bump d3-svg-legend in /superset-frontend (#19846) fix: revert chore(deps): bump d3-svg-legend in /superset-frontend (#19846) May 6, 2022
@stephenLYZ
Copy link
Member

LGTM! Let's migrate to Echarts version next!

@villebro
Copy link
Member Author

villebro commented May 6, 2022

LGTM! Let's migrate to Echarts version next!

Agreed @stephenLYZ , it seems like a perfect drop in replacement!

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@villebro villebro merged commit f144de4 into apache:master May 6, 2022
@villebro villebro deleted the villebro/revert-d3-svg-legend branch May 6, 2022 10:11
villebro added a commit that referenced this pull request May 6, 2022
villebro pushed a commit to preset-io/superset that referenced this pull request May 6, 2022
More hackery!

removing some giant padding

lint

add dedicated mobile collapse button

style action buttons

replace down with up arrow

Make it sticky

Adding viewport tag

Making Filters a Sidebar Again (and letting the header scroll away)

delint

Revert "chore(deps): bump d3-svg-legend in /superset-frontend (apache#19846)" (apache#19972)

This reverts commit 528a9cd.

customize font sizes
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants