Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change copy to Edit chart in Dashboard dropdown #20032

Merged
merged 2 commits into from
May 16, 2022
Merged

chore: Change copy to Edit chart in Dashboard dropdown #20032

merged 2 commits into from
May 16, 2022

Conversation

geido
Copy link
Member

@geido geido commented May 11, 2022

SUMMARY

As shown in the screenshot

BEFORE

Clipboard 2022-21-04 at 1 28 26 PM

AFTER

Screen Shot 2022-05-11 at 19 13 28

TESTING INSTRUCTIONS

  1. Go to a Dashboard
  2. Open the dropdown
  3. Make sure the copy is right

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #20032 (b2a4417) into master (4435e53) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head b2a4417 differs from pull request most recent head a45021b. Consider uploading reports for the commit a45021b to get more accurate results

@@            Coverage Diff             @@
##           master   #20032      +/-   ##
==========================================
- Coverage   66.37%   66.33%   -0.05%     
==========================================
  Files        1715     1713       -2     
  Lines       64179    64083      -96     
  Branches     6753     6734      -19     
==========================================
- Hits        42602    42509      -93     
- Misses      19859    19863       +4     
+ Partials     1718     1711       -7     
Flag Coverage Δ
javascript 51.27% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dashboard/components/SliceHeaderControls/index.tsx 66.25% <ø> (+2.39%) ⬆️
...set-frontend/src/components/ReportModal/styles.tsx 87.87% <0.00%> (-12.13%) ⬇️
...ns/legacy-plugin-chart-map-box/src/controlPanel.ts 25.00% <0.00%> (-8.34%) ⬇️
...rc/explore/components/ExploreChartHeader/index.jsx 43.10% <0.00%> (-8.25%) ⬇️
...rset-frontend/src/explore/exploreUtils/formData.ts 85.71% <0.00%> (-3.18%) ⬇️
superset-frontend/src/reports/actions/reports.js 36.36% <0.00%> (-3.04%) ⬇️
superset/examples/helpers.py 80.00% <0.00%> (-2.61%) ⬇️
...explore/components/controls/ColorPickerControl.jsx 86.66% <0.00%> (-1.57%) ⬇️
...ols/FilterControl/AdhocFilterEditPopover/index.jsx 68.18% <0.00%> (-1.39%) ⬇️
superset-frontend/src/views/CRUD/hooks.ts 46.15% <0.00%> (-1.16%) ⬇️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d4318...a45021b. Read the comment docs.

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@geido geido merged commit 2650131 into apache:master May 16, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants