Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Direct Linking issue on report list: 404 status code. #20033

Merged

Conversation

codemaster08240328
Copy link
Contributor

SUMMARY

The current superset throws 404 when you try to go to report page directly (/report/list)

The problem was that the ReportView class was not registered into FAB.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
[DEV] Superset - 11 May 2022 - Watch Video

AFTER:
[DEV] Superset - 11 May 2022 - Watch Video

TESTING INSTRUCTIONS

  • Log into a workspace
  • Add /report/list to the end of the url

Another method:

  • Navigating to reports in the app, then try to refresh

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #20033 (1a54f13) into master (3a379af) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 1a54f13 differs from pull request most recent head a30975f. Consider uploading reports for the commit a30975f to get more accurate results

@@            Coverage Diff             @@
##           master   #20033      +/-   ##
==========================================
- Coverage   66.33%   66.30%   -0.04%     
==========================================
  Files        1713     1713              
  Lines       64083    64084       +1     
  Branches     6734     6734              
==========================================
- Hits        42509    42490      -19     
- Misses      19863    19883      +20     
  Partials     1711     1711              
Flag Coverage Δ
hive 53.66% <100.00%> (+<0.01%) ⬆️
mysql 82.03% <100.00%> (+<0.01%) ⬆️
postgres ?
presto 53.52% <100.00%> (+<0.01%) ⬆️
python 82.46% <100.00%> (-0.07%) ⬇️
sqlite 81.82% <100.00%> (+<0.01%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/initialization/__init__.py 91.07% <100.00%> (-0.33%) ⬇️
superset/sql_validators/postgres.py 50.00% <0.00%> (-50.00%) ⬇️
superset/sql_validators/__init__.py 80.00% <0.00%> (-20.00%) ⬇️
superset/reports/commands/log_prune.py 85.71% <0.00%> (-3.58%) ⬇️
superset/databases/commands/validate_sql.py 92.00% <0.00%> (-2.00%) ⬇️
superset/db_engine_specs/postgres.py 95.45% <0.00%> (-1.82%) ⬇️
superset/commands/importers/v1/utils.py 92.20% <0.00%> (-1.30%) ⬇️
superset/common/query_object.py 94.73% <0.00%> (-0.53%) ⬇️
superset/views/base_api.py 97.97% <0.00%> (-0.41%) ⬇️
superset/reports/commands/execute.py 91.14% <0.00%> (-0.37%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a379af...a30975f. Read the comment docs.

@rusackas rusackas merged commit 9cf9f97 into apache:master May 11, 2022
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request May 11, 2022
@sadpandajoe
Copy link
Member

🏷️ preset:2022.19

philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.19 Preset-Patch size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants