Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create a generic header component for Explore and Dashboard #20044

Merged
merged 5 commits into from
May 13, 2022

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented May 12, 2022

SUMMARY

This PR implements a generic Header component for Explore and Dashboard pages. The goal is to be able to reuse the header already implemented in Explore and use it in Dashboards, thus unblocking the redesign of dashboard header project.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

No visual changes

TESTING INSTRUCTIONS

Explore header should work exactly like before

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #20044 (926cb05) into master (ca9766c) will increase coverage by 0.00%.
The diff coverage is 79.14%.

❗ Current head 926cb05 differs from pull request most recent head 8f17cc3. Consider uploading reports for the commit 8f17cc3 to get more accurate results

@@           Coverage Diff           @@
##           master   #20044   +/-   ##
=======================================
  Coverage   66.35%   66.35%           
=======================================
  Files        1712     1713    +1     
  Lines       64080    64102   +22     
  Branches     6744     6746    +2     
=======================================
+ Hits        42520    42538   +18     
- Misses      19847    19849    +2     
- Partials     1713     1715    +2     
Flag Coverage Δ
javascript 51.32% <81.13%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../plugin-chart-echarts/src/Funnel/transformProps.ts 71.73% <ø> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <ø> (ø)
...ins/plugin-chart-echarts/src/Pie/transformProps.ts 55.07% <ø> (ø)
...s/plugin-chart-echarts/src/Radar/transformProps.ts 0.00% <ø> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts 57.89% <ø> (ø)
...lugin-chart-echarts/src/Timeseries/transformers.ts 51.63% <ø> (ø)
...plugin-chart-echarts/src/Treemap/transformProps.ts 51.51% <ø> (ø)
...ins/preset-chart-xy/src/components/Line/Encoder.ts 100.00% <ø> (ø)
...uperset-frontend/src/components/FaveStar/index.tsx 100.00% <ø> (ø)
...ponents/ReportModal/HeaderReportDropdown/index.tsx 69.33% <ø> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca9766c...8f17cc3. Read the comment docs.

@kgabryje
Copy link
Member Author

/testenv up

@github-actions
Copy link
Contributor

@kgabryje Ephemeral environment spinning up at http://35.162.156.179:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kgabryje kgabryje merged commit 1cd002e into apache:master May 13, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
…pache#20044)

* chore: Create a generic header component for Explore and Dashboard

* Add tests

* Fix undefined error

* Remove duplicate code

* Fix cypress test
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XXL 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants