Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: using lazy_gettext instead of gettext #20079

Conversation

aehanno
Copy link
Contributor

@aehanno aehanno commented May 16, 2022

SUMMARY

using gettext instead of lazy_gettext

ADDITIONAL INFORMATION

Fixes #20060

@aehanno
Copy link
Contributor Author

aehanno commented Jun 6, 2022

@villebro, PR you ask me to create from an other one

@aehanno aehanno changed the title fix : using lazy_gettext instead of gettext fix: using lazy_gettext instead of gettext Jun 15, 2022
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the tests is failing due to the _LazyString object not being JSON serializable. Check out this stackoverflow post on how to address this: https://stackoverflow.com/questions/26124581/flask-json-serializable-error-because-of-flask-babel

@aehanno aehanno requested a review from villebro October 5, 2022 15:45
@rusackas
Copy link
Member

rusackas commented Jun 5, 2023

@aehanno is there any intent to follow through on this, or shall we close it out?

@john-bodley
Copy link
Member

@villebro is this somewhat related to the issue we discussed yesterday?

@aehanno
Copy link
Contributor Author

aehanno commented Oct 27, 2023

@aehanno is there any intent to follow through on this, or shall we close it out?

Hey ! Yes, but I was wating to know if my correction it's okay before doing another rebase

@rusackas
Copy link
Member

@aehanno is there any intent to follow through on this, or shall we close it out?

Hey ! Yes, but I was wating to know if my correction it's okay before doing another rebase

Oh no! That went under my radar for FAR too long. I don't think there's any objection to the PR if you want to rebase it. (@villebro can correct me if I'm wrong, of course).

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8f8e7c2) 67.16% compared to head (e170af4) 59.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20079      +/-   ##
==========================================
- Coverage   67.16%   59.59%   -7.58%     
==========================================
  Files        1894     1894              
  Lines       74176    74176              
  Branches     8243     8243              
==========================================
- Hits        49820    44203    -5617     
- Misses      22287    27904    +5617     
  Partials     2069     2069              
Flag Coverage Δ
hive 53.79% <ø> (?)
mysql ?
postgres ?
presto 53.74% <ø> (?)
python 62.51% <ø> (-15.69%) ⬇️
sqlite ?
unit 56.40% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aehanno aehanno closed this Jan 25, 2024
@aehanno aehanno deleted the using-lazygettex-instead-of-gettext branch January 25, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing French Translation
4 participants