-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: using lazy_gettext instead of gettext #20079
fix: using lazy_gettext instead of gettext #20079
Conversation
@villebro, PR you ask me to create from an other one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the tests is failing due to the _LazyString
object not being JSON serializable. Check out this stackoverflow post on how to address this: https://stackoverflow.com/questions/26124581/flask-json-serializable-error-because-of-flask-babel
@aehanno is there any intent to follow through on this, or shall we close it out? |
@villebro is this somewhat related to the issue we discussed yesterday? |
Hey ! Yes, but I was wating to know if my correction it's okay before doing another rebase |
Oh no! That went under my radar for FAR too long. I don't think there's any objection to the PR if you want to rebase it. (@villebro can correct me if I'm wrong, of course). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20079 +/- ##
==========================================
- Coverage 67.16% 59.59% -7.58%
==========================================
Files 1894 1894
Lines 74176 74176
Branches 8243 8243
==========================================
- Hits 49820 44203 -5617
- Misses 22287 27904 +5617
Partials 2069 2069
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SUMMARY
using gettext instead of lazy_gettext
ADDITIONAL INFORMATION
Fixes #20060