Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "Week Staring Monday" time grain for BigQuery #20091

Merged
merged 2 commits into from
May 26, 2022
Merged

fix: "Week Staring Monday" time grain for BigQuery #20091

merged 2 commits into from
May 26, 2022

Conversation

ramunas-omnisend
Copy link
Contributor

@ramunas-omnisend ramunas-omnisend commented May 17, 2022

SUMMARY

Time granularity "Week Staring Monday" added for BigQuery

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

Create a chart for BigQuery. Choose "Week starting Monday". Ensure data is aggregated by week with the first day being Monday.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • [ X] Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #20091 (5326908) into master (e69f629) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 5326908 differs from pull request most recent head d26c36f. Consider uploading reports for the commit d26c36f to get more accurate results

@@            Coverage Diff             @@
##           master   #20091      +/-   ##
==========================================
- Coverage   66.45%   66.45%   -0.01%     
==========================================
  Files        1721     1721              
  Lines       64481    64481              
  Branches     6796     6796              
==========================================
- Hits        42854    42853       -1     
- Misses      19897    19898       +1     
  Partials     1730     1730              
Flag Coverage Δ
hive 53.69% <ø> (ø)
mysql 82.13% <ø> (ø)
postgres 82.19% <ø> (ø)
presto 53.55% <ø> (ø)
python 82.61% <ø> (-0.01%) ⬇️
sqlite 81.93% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/bigquery.py 84.84% <ø> (ø)
superset/initialization/__init__.py 91.13% <0.00%> (-0.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e69f629...d26c36f. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this!

@villebro villebro merged commit 694f75d into apache:master May 26, 2022
michael-s-molina pushed a commit that referenced this pull request May 26, 2022
* Week Staring From Monday added for BQ

* lint fix

(cherry picked from commit 694f75d)
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* Week Staring From Monday added for BQ

* lint fix
@mistercrunch mistercrunch added 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants