feat: add statsd metrics for notifications #20158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20158 +/- ##
==========================================
- Coverage 66.45% 66.27% -0.19%
==========================================
Files 1721 1722 +1
Lines 64513 64656 +143
Branches 6806 6821 +15
==========================================
- Hits 42875 42849 -26
- Misses 19906 20074 +168
- Partials 1732 1733 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
craig-rueda
reviewed
May 23, 2022
| metric_prefix_ = metric_prefix or f.__name__ | ||
| try: | ||
| result = f(*args, **kwargs) | ||
| current_app.config["STATS_LOGGER"].gauge(f"{metric_prefix_}.ok", 1) |
There was a problem hiding this comment.
Does this allow for the end user to set a custom prefix?
There was a problem hiding this comment.
yes, when creating a custom statsd logger class
craig-rueda
approved these changes
May 26, 2022
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
* feat: add statsd metrics for notifications * fix import * fix lint * add decorator arg for custom prefix * add tests
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add a statsd gauge metric for Slack and email notifications.
We want to add more visibility for Alerts & Reports notifications: how many errors, how many notifications were sent
ADDITIONAL INFORMATION