Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Virtual dataset duplication #20309

Merged
merged 21 commits into from
Aug 26, 2022

Conversation

reesercollins
Copy link
Contributor

@reesercollins reesercollins commented Jun 8, 2022

SUMMARY

There is currently no way for users to copy datasets in superset. Even though they can copy the SQL of a dataset, any changes we make to the field types (e.g., in cases where we turn long, complex types into JSON, or advanced types as described in #17852) cannot be easily copied.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

See #20245

TESTING INSTRUCTIONS

There should be a button in the actions column for virtual datasets which duplicates them with the provided name when clicked.

ADDITIONAL INFORMATION

  • Has associated issue: [SIP-83] Proposal for copying virtual datasets #20232
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@reesercollins reesercollins changed the title [WIP] feat: Virtual dataset duplication feat: Virtual dataset duplication Jun 22, 2022
@reesercollins reesercollins marked this pull request as ready for review June 22, 2022 18:11
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #20309 (bcf7244) into master (0945d4a) will increase coverage by 0.19%.
The diff coverage is 66.21%.

❗ Current head bcf7244 differs from pull request most recent head 5f74040. Consider uploading reports for the commit 5f74040 to get more accurate results

@@            Coverage Diff             @@
##           master   #20309      +/-   ##
==========================================
+ Coverage   66.17%   66.36%   +0.19%     
==========================================
  Files        1757     1767      +10     
  Lines       66867    67153     +286     
  Branches     7077     7132      +55     
==========================================
+ Hits        44246    44563     +317     
+ Misses      20812    20765      -47     
- Partials     1809     1825      +16     
Flag Coverage Δ
javascript 52.13% <56.80%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
...tend/plugins/plugin-chart-handlebars/src/consts.ts 66.66% <ø> (-8.34%) ⬇️
...lugin-chart-handlebars/src/plugin/controlPanel.tsx 50.00% <ø> (-16.67%) ⬇️
...hart-pivot-table/src/react-pivottable/utilities.js 0.00% <0.00%> (ø)
...nd/plugins/plugin-chart-table/src/controlPanel.tsx 45.58% <ø> (-0.79%) ⬇️
...frontend/src/SqlLab/components/SqlEditor/index.jsx 51.36% <0.00%> (ø)
...d/src/SqlLab/components/TabbedSqlEditors/index.jsx 56.11% <ø> (ø)
...et-frontend/src/SqlLab/reducers/getInitialState.js 46.42% <ø> (ø)
superset-frontend/src/SqlLab/reducers/sqlLab.js 33.33% <ø> (ø)
... and 153 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@reesercollins reesercollins force-pushed the feature/CLDN-1171-upstream branch 9 times, most recently from aba1179 to 8b1abd8 Compare June 22, 2022 19:35
@yousoph
Copy link
Member

yousoph commented Jun 29, 2022

/testenv up

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://52.88.76.216:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@lyndsiWilliams lyndsiWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this looks great! Just a quick nit, also would you mind writing frontend tests for this?

Copy link
Member

@lyndsiWilliams lyndsiWilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@rusackas rusackas merged commit 16032ed into apache:master Aug 26, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

sadpandajoe added a commit to preset-io/superset that referenced this pull request Aug 31, 2022
sadpandajoe added a commit to preset-io/superset that referenced this pull request Sep 15, 2022
jinghua-qa added a commit to preset-io/superset that referenced this pull request Sep 19, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants