Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update connection modal to use existing catalog #20372

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Jun 14, 2022

SUMMARY

This pr fixes an issue when user hits finish on the dbconnection modal and is unable to exit the screen because parameters field is not sent when validating, causing an db error.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after

Screen.Recording.2022-06-14.at.9.12.24.AM.mov

TESTING INSTRUCTIONS

Go to dbconnection modal for gsheets and enter in you creds. After hitting connect, clicking finish on the next step should exit the modal back to listview.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

AAfghahi
AAfghahi previously approved these changes Jun 14, 2022
Copy link
Member

@AAfghahi AAfghahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Make sure to delete the console log

@AAfghahi AAfghahi dismissed their stale review June 14, 2022 14:14

changed mine

@eschutho eschutho closed this Jun 14, 2022
@eschutho eschutho reopened this Jun 14, 2022
@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #20372 (db45e69) into master (72e5e57) will decrease coverage by 0.12%.
The diff coverage is 73.68%.

❗ Current head db45e69 differs from pull request most recent head b1c6126. Consider uploading reports for the commit b1c6126 to get more accurate results

@@            Coverage Diff             @@
##           master   #20372      +/-   ##
==========================================
- Coverage   66.64%   66.52%   -0.13%     
==========================================
  Files        1738     1739       +1     
  Lines       65060    65143      +83     
  Branches     6885     6902      +17     
==========================================
- Hits        43360    43336      -24     
- Misses      19953    20054     +101     
- Partials     1747     1753       +6     
Flag Coverage Δ
hive ?
javascript 51.71% <71.51%> (+0.10%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Icons/index.tsx 100.00% <ø> (ø)
superset-frontend/src/components/Timer/index.tsx 78.94% <ø> (ø)
...ashboard/components/BuilderComponentPane/index.tsx 78.94% <0.00%> (ø)
.../src/explore/components/ControlPanelsContainer.tsx 79.80% <ø> (ø)
...et-frontend/src/explore/controlPanels/sections.tsx 100.00% <ø> (ø)
...rontend/src/views/CRUD/dashboard/DashboardList.tsx 57.14% <0.00%> (-0.96%) ⬇️
...c/views/CRUD/data/database/DatabaseModal/index.tsx 32.16% <0.00%> (-0.18%) ⬇️
superset/datasets/api.py 88.52% <ø> (ø)
superset/reports/commands/alert.py 96.55% <ø> (ø)
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 54.60% <16.66%> (-0.71%) ⬇️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72e5e57...b1c6126. Read the comment docs.

@AAfghahi AAfghahi merged commit 160e674 into apache:master Jun 14, 2022
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Jun 14, 2022
* fix: update connection modal to use existing catalog

* remove console

(cherry picked from commit 160e674)
@sadpandajoe
Copy link
Member

🏷️ preset:2022.23

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Jun 14, 2022
* fix: update connection modal to use existing catalog

* remove console

(cherry picked from commit 160e674)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.23 preset-io size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants