Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(database-modal): form in database model effects results of the database list #20487

Merged
merged 1 commit into from
Jun 30, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

The form in the database modal affects the results of the database list and the form value will be reset.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

2022-06-24.4.37.27.mov

after

2022-06-24.4.36.25.mov

TESTING INSTRUCTIONS

  1. Refresh into the database list page
  2. Edit database
  3. Switch to the ADVANCED tab
  4. Open SQL lab collapsed item
  5. See the result

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #20487 (e0ff520) into master (44f0b51) will not change coverage.
The diff coverage is 100.00%.

❗ Current head e0ff520 differs from pull request most recent head 59bee70. Consider uploading reports for the commit 59bee70 to get more accurate results

@@           Coverage Diff           @@
##           master   #20487   +/-   ##
=======================================
  Coverage   66.75%   66.75%           
=======================================
  Files        1740     1740           
  Lines       65172    65172           
  Branches     6900     6900           
=======================================
  Hits        43505    43505           
  Misses      19918    19918           
  Partials     1749     1749           
Flag Coverage Δ
javascript 51.80% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ase/DatabaseModal/DatabaseConnectionForm/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44f0b51...59bee70. Read the comment docs.

@zhaoyongjie zhaoyongjie self-requested a review June 30, 2022 08:21
@zhaoyongjie zhaoyongjie merged commit 932e304 into apache:master Jun 30, 2022
michael-s-molina pushed a commit that referenced this pull request Jul 6, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/XS v2.0 🍒 2.0.0 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants