Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm): add liveness and readiness for deployment webserver #20567

Merged
merged 11 commits into from
Aug 8, 2022
Merged

feat(helm): add liveness and readiness for deployment webserver #20567

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
ebcaab9
feat(helm): add liveness and readiness for deployment webserver
Jun 30, 2022
4e19667
feat(helm): add example in values
Jun 30, 2022
eacf980
feat(helm): move config probes under supersetNode
Jul 4, 2022
ab8adba
feat(helm): bump chart.yaml
Jul 6, 2022
c8ecafd
Merge branch 'master' into feat/helm/add-k8s-probes
jplanckeel Jul 6, 2022
ef11419
fix(helm): remove default values in template and use values.yaml
Jul 7, 2022
b2bb4b7
fix(git): bump chart verison
Jul 8, 2022
08a51df
fix(json): update the schema to get CI passing
Jul 12, 2022
1b337a6
Merge branch 'master' into feat/helm/add-k8s-probes
craig-rueda Jul 25, 2022
16cd216
fix(helm): correct path for values readiness
jplanckeel Aug 8, 2022
31ceced
Merge branch 'master' into feat/helm/add-k8s-probes
jplanckeel Aug 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helm/superset/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ maintainers:
- name: craig-rueda
email: craig@craigrueda.com
url: https://github.com/craig-rueda
version: 0.6.6
version: 0.6.7
dependencies:
- name: postgresql
version: 11.1.22
Expand Down
18 changes: 18 additions & 0 deletions helm/superset/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,24 @@ spec:
- name: http
containerPort: {{ .Values.service.port }}
protocol: TCP
livenessProbe:
httpGet:
path: /health
port: http
initialDelaySeconds: {{ .Values.supersetNode.livenessProbe.initialDelaySeconds }}
timeoutSeconds: {{ .Values.supersetNode.livenessProbe.timeoutSeconds }}
failureThreshold: {{ .Values.supersetNode.livenessProbe.failureThreshold }}
periodSeconds: {{ .Values.supersetNode.livenessProbe.periodSeconds }}
successThreshold: {{ .Values.supersetNode.livenessProbe.successThreshold }}
readinessProbe:
httpGet:
path: /health
port: http
initialDelaySeconds: {{ .supersetNode.Values.readinessProbe.initialDelaySeconds }}
jplanckeel marked this conversation as resolved.
Show resolved Hide resolved
timeoutSeconds: {{ .Values.supersetNode.readinessProbe.timeoutSeconds }}
failureThreshold: {{ .Values.supersetNode.readinessProbe.failureThreshold }}
periodSeconds: {{ .Values.supersetNode.readinessProbe.periodSeconds }}
successThreshold: {{ .Values.supersetNode.readinessProbe.successThreshold }}
resources:
{{- if .Values.supersetNode.resources }}
{{ toYaml .Values.supersetNode.resources | indent 12 }}
Expand Down
56 changes: 56 additions & 0 deletions helm/superset/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,62 @@
"podLabels": {
"$ref": "https://raw.githubusercontent.com/yannh/kubernetes-json-schema/master/v1.23.0/_definitions.json##/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta/properties/labels"
},
"livenessProbe": {
"type": "object",
"additionalProperties": false,
"properties": {
"initialDelaySeconds": {
"type": "integer"
},
"timeoutSeconds": {
"type": "integer"
},
"failureThreshold": {
"type": "integer"
},
"periodSeconds": {
"type": "integer"
},
"successThreshold": {
"type": "integer"
}
},
"required": [
"initialDelaySeconds",
"timeoutSeconds",
"failureThreshold",
"periodSeconds",
"successThreshold"
]
},
"readinessProbe": {
"type": "object",
"additionalProperties": false,
"properties": {
"initialDelaySeconds": {
"type": "integer"
},
"timeoutSeconds": {
"type": "integer"
},
"failureThreshold": {
"type": "integer"
},
"periodSeconds": {
"type": "integer"
},
"successThreshold": {
"type": "integer"
}
},
"required": [
"initialDelaySeconds",
"timeoutSeconds",
"failureThreshold",
"periodSeconds",
"successThreshold"
]
},
"resources": {
"type": "object"
},
Expand Down
12 changes: 12 additions & 0 deletions helm/superset/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,18 @@ supersetNode:
podAnnotations: {}
## Labels to be added to supersetNode pods
podLabels: {}
livenessProbe:
initialDelaySeconds: 15
timeoutSeconds: 1
failureThreshold: 3
periodSeconds: 15
successThreshold: 1
readinessProbe:
initialDelaySeconds: 15
timeoutSeconds: 1
failureThreshold: 3
periodSeconds: 15
successThreshold: 1
# Resource settings for the supersetNode pods - these settings overwrite might existing values from the global resources object defined above.
resources: {}
# limits:
Expand Down