Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add user agent to Databricks requests #20660

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

betodealmeida
Copy link
Member

SUMMARY

Set a "User-Agent" header on the Databricks connector.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #20660 (f8be567) into master (0ce0c6e) will decrease coverage by 0.00%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##           master   #20660      +/-   ##
==========================================
- Coverage   66.83%   66.83%   -0.01%     
==========================================
  Files        1753     1753              
  Lines       65808    65817       +9     
  Branches     7001     7001              
==========================================
+ Hits        43984    43989       +5     
- Misses      20035    20039       +4     
  Partials     1789     1789              
Flag Coverage Δ
hive 53.88% <60.00%> (+<0.01%) ⬆️
mysql 82.37% <60.00%> (-0.01%) ⬇️
postgres 82.44% <60.00%> (-0.01%) ⬇️
presto 53.74% <60.00%> (+<0.01%) ⬆️
python 82.88% <60.00%> (-0.01%) ⬇️
sqlite 82.23% <60.00%> (-0.01%) ⬇️
unit 50.83% <60.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/databricks.py 82.35% <55.55%> (-9.96%) ⬇️
superset/constants.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ce0c6e...f8be567. Read the comment docs.

@dungdm93
Copy link
Contributor

User-Agent is very useful to backend analysis.
Trino should be follow this by set X-Trino-Source header

@betodealmeida betodealmeida merged commit 2a4c7cf into apache:master Jul 20, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants