Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): Save Dataset Modal Multiple overwrites #20691

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

Antonio-RiveroMartnez
Copy link
Member

SUMMARY

  • Stop clearing the selected dataset after overwriting so users can overwrite as many times as they see fit
  • There's a new AsyncSelect we should use now

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
error

AFTER:
test

TESTING INSTRUCTIONS

  1. Go to "SQL Editor"
  2. Edit SQL query
    e.g.
SELECT "YEAR",
       "MONTH",
       "DAY"
FROM public.flights
LIMIT 10
  1. Run the query and then click the "Create Chart" button
  2. Select the "Save as new" option and enter the name
  3. Click the "Save & Explore" button
  4. Repeat steps 1-3
  5. Select the "Overwrite existing" and select recently created dataset
  6. Click the "Save & Explore" and click the "Overwrite & Explore" button

Expected results:

  1. A new tab must open with the chart
  2. If you go back to the tab that has the dropdown open you can repeat as many times as you want step 8 from above

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

- Stop clearing the selected dataset after overwritting so users can overwrite as many times as they see fit
- There's a new AsyncSelect we should use now
@Antonio-RiveroMartnez Antonio-RiveroMartnez changed the title Save Dataset Modal: fix(sqllab): Save Dataset Modal Multiple overwrites Jul 12, 2022
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #20691 (52f099b) into master (ff5b4bc) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #20691   +/-   ##
=======================================
  Coverage   66.85%   66.85%           
=======================================
  Files        1753     1753           
  Lines       65839    65838    -1     
  Branches     7007     7007           
=======================================
  Hits        44017    44017           
+ Misses      20036    20035    -1     
  Partials     1786     1786           
Flag Coverage Δ
javascript 51.95% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/SqlLab/components/SaveDatasetModal/index.tsx 35.06% <0.00%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff5b4bc...52f099b. Read the comment docs.

@rusackas rusackas merged commit 5510af3 into apache:master Jul 13, 2022
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Jul 13, 2022
- Stop clearing the selected dataset after overwritting so users can overwrite as many times as they see fit
- There's a new AsyncSelect we should use now

(cherry picked from commit 5510af3)
@Antonio-RiveroMartnez Antonio-RiveroMartnez deleted the FIX-52157 branch July 14, 2022 13:31
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.27 size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants