-
Notifications
You must be signed in to change notification settings - Fork 13.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow more HTML tags in report description #20908
feat: allow more HTML tags in report description #20908
Conversation
"p", | ||
"strong", | ||
"ul", | ||
] + TABLE_TAGS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is basically bleach.ALLOWED_TAGS + ["br", "p", "div"]
. Enumerate all of them so you don't have to jump to the source code of bleach
to see the full list.
Codecov Report
@@ Coverage Diff @@
## master #20908 +/- ##
===========================================
- Coverage 66.31% 54.86% -11.45%
===========================================
Files 1758 1758
Lines 67008 67010 +2
Branches 7107 7107
===========================================
- Hits 44437 36766 -7671
- Misses 20749 28422 +7673
Partials 1822 1822
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
@@ -23,6 +23,7 @@ | |||
from typing import Any, Dict, Optional | |||
|
|||
import bleach | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ktmud you'll have to remove this to get CI to pass.
5eeb6a7
to
8a6eaa7
Compare
8a6eaa7
to
0c44dee
Compare
SUMMARY
Our users want to write multi-line descriptions for alerts & reports. This PR adds
<br>, <p>, <div>
, as well as HTML table related tags to the list of allowed tags.Slack messages need to be handled differently. We'll address it in future PRs if necessary.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Unit test
ADDITIONAL INFORMATION